Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 1227823009: Move add/removeEventListener() to custom bindings (Closed)

Created:
5 years, 5 months ago by philipj_slow
Modified:
5 years, 5 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, Inactive, vivekg
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Move add/removeEventListener() to custom bindings This is to prepare for measuring the impact of throwing an exception when these functions are called with < 2 arguments, as per spec. This has to be done by either tweaking the bindings generator or in custom bindings, and since this is temporary custom bindings seem better. This CL merely copies the generated bindings to custom bindings, with the minimal changes needed for it to compile. A follow-up CL will add the actual use counters. BUG=353484

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -5 lines) Patch
M Source/bindings/core/v8/custom/V8EventTargetCustom.cpp View 1 chunk +81 lines, -3 lines 0 comments Download
M Source/core/events/EventTarget.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227823009/1
5 years, 5 months ago (2015-07-09 22:08:04 UTC) #2
philipj_slow
PTAL, and please advise if you see a better way to get the use counter ...
5 years, 5 months ago (2015-07-09 22:08:38 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-09 23:25:32 UTC) #6
haraken
Maybe would it be worth adding [Custom=CallPrologue] (just like [Custom=CallEpilogue])? Then we can throw an ...
5 years, 5 months ago (2015-07-09 23:37:52 UTC) #7
philipj_slow
5 years, 5 months ago (2015-07-10 07:41:20 UTC) #8
Message was sent while issue was closed.
On 2015/07/09 23:37:52, haraken wrote:
> Maybe would it be worth adding [Custom=CallPrologue] (just like
> [Custom=CallEpilogue])? Then we can throw an exception in the prologue.

An excellent suggestion, thank you! I'll do that in the other CL and close this
one.

Powered by Google App Engine
This is Rietveld 408576698