Issue 1227803002: Some fixes for big_red_button.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1227803002: Some fixes for big_red_button.py (Closed)

Created:
5 years, 5 months ago by Cutch

Modified:
5 years, 5 months ago

Reviewers:
eseidel1, eseidel

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	sky/tools/big_red_button.py	View		2 chunks	+4 lines, -3 lines	0 comments	Download

Total messages: 5 (2 generated)

eseidel

Does normpath or abspath just include expanduser for you? in any case lgtm.

5 years, 5 months ago (2015-07-08 21:05:05 UTC) #4

Cutch

5 years, 5 months ago (2015-07-08 21:07:09 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8dd0b8d8f96f3e4df2b1091e630abaa3d8f900ec (presubmit successful).