Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: Source/modules/websockets/WorkerWebSocketChannel.h

Issue 1227783004: Fix virtual/override/final usage in Source/modules/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/websockets/DocumentWebSocketChannelTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/websockets/WorkerWebSocketChannel.h
diff --git a/Source/modules/websockets/WorkerWebSocketChannel.h b/Source/modules/websockets/WorkerWebSocketChannel.h
index 06410602b1440311214c59b9b3dddbe993a9a394..a14a36df4e31c660e846bc7029f694160fdaa460 100644
--- a/Source/modules/websockets/WorkerWebSocketChannel.h
+++ b/Source/modules/websockets/WorkerWebSocketChannel.h
@@ -60,24 +60,24 @@ public:
{
return new WorkerWebSocketChannel(workerGlobalScope, client, sourceURL, lineNumber);
}
- virtual ~WorkerWebSocketChannel();
+ ~WorkerWebSocketChannel() override;
// WebSocketChannel functions.
- virtual bool connect(const KURL&, const String& protocol) override;
- virtual void send(const CString&) override;
- virtual void send(const DOMArrayBuffer&, unsigned byteOffset, unsigned byteLength) override;
- virtual void send(PassRefPtr<BlobDataHandle>) override;
- virtual void sendTextAsCharVector(PassOwnPtr<Vector<char>>) override
+ bool connect(const KURL&, const String& protocol) override;
+ void send(const CString&) override;
+ void send(const DOMArrayBuffer&, unsigned byteOffset, unsigned byteLength) override;
+ void send(PassRefPtr<BlobDataHandle>) override;
+ void sendTextAsCharVector(PassOwnPtr<Vector<char>>) override
{
ASSERT_NOT_REACHED();
}
- virtual void sendBinaryAsCharVector(PassOwnPtr<Vector<char>>) override
+ void sendBinaryAsCharVector(PassOwnPtr<Vector<char>>) override
{
ASSERT_NOT_REACHED();
}
- virtual void close(int code, const String& reason) override;
- virtual void fail(const String& reason, MessageLevel, const String&, unsigned) override;
- virtual void disconnect() override; // Will suppress didClose().
+ void close(int code, const String& reason) override;
+ void fail(const String& reason, MessageLevel, const String&, unsigned) override;
+ void disconnect() override; // Will suppress didClose().
DECLARE_VIRTUAL_TRACE();
@@ -88,7 +88,7 @@ public:
WTF_MAKE_NONCOPYABLE(Peer);
public:
Peer(Bridge*, PassRefPtr<WorkerLoaderProxy>, WebSocketChannelSyncHelper*);
- virtual ~Peer();
+ ~Peer() override;
// sourceURLAtConnection and lineNumberAtConnection parameters may
// be shown when the connection fails.
@@ -105,13 +105,13 @@ public:
DECLARE_VIRTUAL_TRACE();
// WebSocketChannelClient functions.
- virtual void didConnect(const String& subprotocol, const String& extensions) override;
- virtual void didReceiveTextMessage(const String& payload) override;
- virtual void didReceiveBinaryMessage(PassOwnPtr<Vector<char>>) override;
- virtual void didConsumeBufferedAmount(uint64_t) override;
- virtual void didStartClosingHandshake() override;
- virtual void didClose(ClosingHandshakeCompletionStatus, unsigned short code, const String& reason) override;
- virtual void didError() override;
+ void didConnect(const String& subprotocol, const String& extensions) override;
+ void didReceiveTextMessage(const String& payload) override;
+ void didReceiveBinaryMessage(PassOwnPtr<Vector<char>>) override;
+ void didConsumeBufferedAmount(uint64_t) override;
+ void didStartClosingHandshake() override;
+ void didClose(ClosingHandshakeCompletionStatus, unsigned short code, const String& reason) override;
+ void didError() override;
private:
Member<Bridge> m_bridge;
« no previous file with comments | « Source/modules/websockets/DocumentWebSocketChannelTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698