Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1765)

Unified Diff: Source/modules/websockets/DOMWebSocket.h

Issue 1227783004: Fix virtual/override/final usage in Source/modules/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/websockets/CloseEvent.h ('k') | Source/modules/websockets/DOMWebSocketTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/websockets/DOMWebSocket.h
diff --git a/Source/modules/websockets/DOMWebSocket.h b/Source/modules/websockets/DOMWebSocket.h
index 2a01578349849b4f214b3a2edb127eb0685cd3c3..27ed56c145e9aed043a7c747782a41086ce52e5a 100644
--- a/Source/modules/websockets/DOMWebSocket.h
+++ b/Source/modules/websockets/DOMWebSocket.h
@@ -69,7 +69,7 @@ public:
// hasPendingActivity() returns true.
static DOMWebSocket* create(ExecutionContext*, const String& url, ExceptionState&);
static DOMWebSocket* create(ExecutionContext*, const String& url, const StringOrStringSequence& protocols, ExceptionState&);
- virtual ~DOMWebSocket();
+ ~DOMWebSocket() override;
enum State {
CONNECTING = 0,
@@ -110,26 +110,26 @@ public:
DEFINE_ATTRIBUTE_EVENT_LISTENER(close);
// EventTarget functions.
- virtual const AtomicString& interfaceName() const override;
- virtual ExecutionContext* executionContext() const override;
+ const AtomicString& interfaceName() const override;
+ ExecutionContext* executionContext() const override;
// ActiveDOMObject functions.
- virtual void contextDestroyed() override;
+ void contextDestroyed() override;
// Prevent this instance from being collected while it's not in CLOSED
// state.
- virtual bool hasPendingActivity() const override;
- virtual void suspend() override;
- virtual void resume() override;
- virtual void stop() override;
+ bool hasPendingActivity() const override;
+ void suspend() override;
+ void resume() override;
+ void stop() override;
// WebSocketChannelClient functions.
- virtual void didConnect(const String& subprotocol, const String& extensions) override;
- virtual void didReceiveTextMessage(const String& message) override;
- virtual void didReceiveBinaryMessage(PassOwnPtr<Vector<char>>) override;
- virtual void didError() override;
- virtual void didConsumeBufferedAmount(uint64_t) override;
- virtual void didStartClosingHandshake() override;
- virtual void didClose(ClosingHandshakeCompletionStatus, unsigned short code, const String& reason) override;
+ void didConnect(const String& subprotocol, const String& extensions) override;
+ void didReceiveTextMessage(const String& message) override;
+ void didReceiveBinaryMessage(PassOwnPtr<Vector<char>>) override;
+ void didError() override;
+ void didConsumeBufferedAmount(uint64_t) override;
+ void didStartClosingHandshake() override;
+ void didClose(ClosingHandshakeCompletionStatus, unsigned short code, const String& reason) override;
DECLARE_VIRTUAL_TRACE();
« no previous file with comments | « Source/modules/websockets/CloseEvent.h ('k') | Source/modules/websockets/DOMWebSocketTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698