Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Unified Diff: Source/modules/webdatabase/InspectorDatabaseAgent.cpp

Issue 1227783004: Fix virtual/override/final usage in Source/modules/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/webdatabase/InspectorDatabaseAgent.h ('k') | Source/modules/webdatabase/SQLTransaction.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webdatabase/InspectorDatabaseAgent.cpp
diff --git a/Source/modules/webdatabase/InspectorDatabaseAgent.cpp b/Source/modules/webdatabase/InspectorDatabaseAgent.cpp
index d964b5b1c8b93bdcda8e70e8f6208540e37c86b4..0d1e3e3edae4f0182065e41392bd489a2f6b2a4d 100644
--- a/Source/modules/webdatabase/InspectorDatabaseAgent.cpp
+++ b/Source/modules/webdatabase/InspectorDatabaseAgent.cpp
@@ -75,7 +75,7 @@ public:
return new StatementCallback(requestCallback);
}
- virtual ~StatementCallback() { }
+ ~StatementCallback() override { }
DEFINE_INLINE_VIRTUAL_TRACE()
{
@@ -83,7 +83,7 @@ public:
SQLStatementCallback::trace(visitor);
}
- virtual bool handleEvent(SQLTransaction*, SQLResultSet* resultSet) override
+ bool handleEvent(SQLTransaction*, SQLResultSet* resultSet) override
{
SQLResultSetRowList* rowList = resultSet->rows();
@@ -119,7 +119,7 @@ public:
return new StatementErrorCallback(requestCallback);
}
- virtual ~StatementErrorCallback() { }
+ ~StatementErrorCallback() override { }
DEFINE_INLINE_VIRTUAL_TRACE()
{
@@ -127,7 +127,7 @@ public:
SQLStatementErrorCallback::trace(visitor);
}
- virtual bool handleEvent(SQLTransaction*, SQLError* error) override
+ bool handleEvent(SQLTransaction*, SQLError* error) override
{
reportTransactionFailed(m_requestCallback.get(), error);
return true;
@@ -146,7 +146,7 @@ public:
return new TransactionCallback(sqlStatement, requestCallback);
}
- virtual ~TransactionCallback() { }
+ ~TransactionCallback() override { }
DEFINE_INLINE_VIRTUAL_TRACE()
{
@@ -154,7 +154,7 @@ public:
SQLTransactionCallback::trace(visitor);
}
- virtual bool handleEvent(SQLTransaction* transaction) override
+ bool handleEvent(SQLTransaction* transaction) override
{
if (!m_requestCallback->isActive())
return true;
@@ -180,7 +180,7 @@ public:
return new TransactionErrorCallback(requestCallback);
}
- virtual ~TransactionErrorCallback() { }
+ ~TransactionErrorCallback() override { }
DEFINE_INLINE_VIRTUAL_TRACE()
{
@@ -188,7 +188,7 @@ public:
SQLTransactionErrorCallback::trace(visitor);
}
- virtual bool handleEvent(SQLError* error) override
+ bool handleEvent(SQLError* error) override
{
reportTransactionFailed(m_requestCallback.get(), error);
return true;
@@ -206,9 +206,9 @@ public:
return new TransactionSuccessCallback();
}
- virtual ~TransactionSuccessCallback() { }
+ ~TransactionSuccessCallback() override { }
- virtual void handleEvent() override { }
+ void handleEvent() override { }
private:
TransactionSuccessCallback() { }
« no previous file with comments | « Source/modules/webdatabase/InspectorDatabaseAgent.h ('k') | Source/modules/webdatabase/SQLTransaction.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698