Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: Source/modules/serviceworkers/ServiceWorkerRegistration.h

Issue 1227783004: Fix virtual/override/final usage in Source/modules/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/ServiceWorkerRegistration.h
diff --git a/Source/modules/serviceworkers/ServiceWorkerRegistration.h b/Source/modules/serviceworkers/ServiceWorkerRegistration.h
index 477564d85e5407500a393acdebbc4d742b297e5c..12e8727355c17ed5f0a97885ab4136fb7e4e6f84 100644
--- a/Source/modules/serviceworkers/ServiceWorkerRegistration.h
+++ b/Source/modules/serviceworkers/ServiceWorkerRegistration.h
@@ -34,14 +34,14 @@ class ServiceWorkerRegistration final
USING_GARBAGE_COLLECTED_MIXIN(ServiceWorkerRegistration);
public:
// EventTarget overrides.
- virtual const AtomicString& interfaceName() const override;
- virtual ExecutionContext* executionContext() const override { return ActiveDOMObject::executionContext(); }
+ const AtomicString& interfaceName() const override;
+ ExecutionContext* executionContext() const override { return ActiveDOMObject::executionContext(); }
// WebServiceWorkerRegistrationProxy overrides.
- virtual void dispatchUpdateFoundEvent() override;
- virtual void setInstalling(WebServiceWorker*) override;
- virtual void setWaiting(WebServiceWorker*) override;
- virtual void setActive(WebServiceWorker*) override;
+ void dispatchUpdateFoundEvent() override;
+ void setInstalling(WebServiceWorker*) override;
+ void setWaiting(WebServiceWorker*) override;
+ void setActive(WebServiceWorker*) override;
// For CallbackPromiseAdapter.
typedef WebServiceWorkerRegistration WebType;
@@ -62,7 +62,7 @@ public:
DEFINE_ATTRIBUTE_EVENT_LISTENER(updatefound);
- virtual ~ServiceWorkerRegistration() override;
+ ~ServiceWorkerRegistration() override;
// Eager finalization needed to promptly release owned WebServiceWorkerRegistration.
EAGERLY_FINALIZE();
@@ -73,8 +73,8 @@ private:
ServiceWorkerRegistration(ExecutionContext*, PassOwnPtr<WebServiceWorkerRegistration>);
// ActiveDOMObject overrides.
- virtual bool hasPendingActivity() const override;
- virtual void stop() override;
+ bool hasPendingActivity() const override;
+ void stop() override;
OwnPtr<WebServiceWorkerRegistration> m_outerRegistration;
WebServiceWorkerProvider* m_provider;
« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerMessageEvent.h ('k') | Source/modules/serviceworkers/ServiceWorkerThread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698