Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2322)

Unified Diff: Source/modules/screen_orientation/ScreenOrientationController.h

Issue 1227783004: Fix virtual/override/final usage in Source/modules/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/screen_orientation/ScreenOrientationController.h
diff --git a/Source/modules/screen_orientation/ScreenOrientationController.h b/Source/modules/screen_orientation/ScreenOrientationController.h
index 6b886427ef9e2e840a46cffc8319980d4c76dfcc..5400401ea2c59d84ff1b48d517841fda6ebac173 100644
--- a/Source/modules/screen_orientation/ScreenOrientationController.h
+++ b/Source/modules/screen_orientation/ScreenOrientationController.h
@@ -28,7 +28,7 @@ class MODULES_EXPORT ScreenOrientationController final
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(ScreenOrientationController);
WTF_MAKE_NONCOPYABLE(ScreenOrientationController);
public:
- virtual ~ScreenOrientationController();
+ ~ScreenOrientationController() override;
void setOrientation(ScreenOrientation*);
void notifyOrientationChanged();
@@ -51,14 +51,14 @@ private:
static WebScreenOrientationType computeOrientation(const IntRect&, uint16_t);
// Inherited from PlatformEventController.
- virtual void didUpdateData() override;
- virtual void registerWithDispatcher() override;
- virtual void unregisterWithDispatcher() override;
- virtual bool hasLastData() override;
- virtual void pageVisibilityChanged() override;
+ void didUpdateData() override;
+ void registerWithDispatcher() override;
+ void unregisterWithDispatcher() override;
+ bool hasLastData() override;
+ void pageVisibilityChanged() override;
// Inherited from LocalFrameLifecycleObserver.
- virtual void willDetachFrameHost() override;
+ void willDetachFrameHost() override;
unsigned short effectiveAngle(ChromeClient&);
WebScreenOrientationType effectiveType(ChromeClient&);
« no previous file with comments | « Source/modules/screen_orientation/ScreenOrientation.h ('k') | Source/modules/screen_orientation/ScreenOrientationDispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698