Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1542)

Unified Diff: Source/modules/presentation/PresentationController.h

Issue 1227783004: Fix virtual/override/final usage in Source/modules/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/presentation/PresentationController.h
diff --git a/Source/modules/presentation/PresentationController.h b/Source/modules/presentation/PresentationController.h
index 29eb1cf3abf67994513299b47ca18f1134f1812a..4d98ca7a4b5400317b077e876df226b4310e0183 100644
--- a/Source/modules/presentation/PresentationController.h
+++ b/Source/modules/presentation/PresentationController.h
@@ -30,7 +30,7 @@ class MODULES_EXPORT PresentationController final
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(PresentationController);
WTF_MAKE_NONCOPYABLE(PresentationController);
public:
- virtual ~PresentationController();
+ ~PresentationController() override;
static PassOwnPtrWillBeRawPtr<PresentationController> create(LocalFrame&, WebPresentationClient*);
@@ -45,10 +45,10 @@ public:
DECLARE_VIRTUAL_TRACE();
// Implementation of WebPresentationController.
- virtual void didStartDefaultSession(WebPresentationSessionClient*) override;
- virtual void didChangeSessionState(WebPresentationSessionClient*, WebPresentationSessionState) override;
- virtual void didReceiveSessionTextMessage(WebPresentationSessionClient*, const WebString&) override;
- virtual void didReceiveSessionBinaryMessage(WebPresentationSessionClient*, const uint8_t* data, size_t length) override;
+ void didStartDefaultSession(WebPresentationSessionClient*) override;
+ void didChangeSessionState(WebPresentationSessionClient*, WebPresentationSessionState) override;
+ void didReceiveSessionTextMessage(WebPresentationSessionClient*, const WebString&) override;
+ void didReceiveSessionBinaryMessage(WebPresentationSessionClient*, const uint8_t* data, size_t length) override;
// Connects the |Presentation| object with this controller.
void setPresentation(Presentation*);
@@ -57,7 +57,7 @@ private:
PresentationController(LocalFrame&, WebPresentationClient*);
// Implementation of LocalFrameLifecycleObserver.
- virtual void willDetachFrameHost() override;
+ void willDetachFrameHost() override;
WebPresentationClient* m_client;
PersistentWillBeMember<Presentation> m_presentation;
« no previous file with comments | « Source/modules/presentation/PresentationAvailabilityCallback.h ('k') | Source/modules/presentation/PresentationSession.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698