Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1345)

Unified Diff: Source/modules/notifications/Notification.h

Issue 1227783004: Fix virtual/override/final usage in Source/modules/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/netinfo/NetworkInformation.h ('k') | Source/modules/permissions/PermissionController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/notifications/Notification.h
diff --git a/Source/modules/notifications/Notification.h b/Source/modules/notifications/Notification.h
index c89970ab9cbe8a140bf47be35f61dee6ea9c60ec..0b6d3df0236518c4de6866310567be8a9be55252 100644
--- a/Source/modules/notifications/Notification.h
+++ b/Source/modules/notifications/Notification.h
@@ -69,7 +69,7 @@ public:
// Used for embedder-created Notification objects. Will initialize the Notification's state as showing.
static Notification* create(ExecutionContext*, int64_t persistentId, const WebNotificationData&);
- virtual ~Notification();
+ ~Notification() override;
void close();
@@ -104,13 +104,13 @@ public:
static void requestPermission(ExecutionContext*, NotificationPermissionCallback* = nullptr);
// EventTarget interface.
- virtual ExecutionContext* executionContext() const override final { return ActiveDOMObject::executionContext(); }
- virtual bool dispatchEvent(PassRefPtrWillBeRawPtr<Event>) override final;
- virtual const AtomicString& interfaceName() const override;
+ ExecutionContext* executionContext() const final { return ActiveDOMObject::executionContext(); }
+ bool dispatchEvent(PassRefPtrWillBeRawPtr<Event>) final;
+ const AtomicString& interfaceName() const override;
// ActiveDOMObject interface.
- virtual void stop() override;
- virtual bool hasPendingActivity() const override;
+ void stop() override;
+ bool hasPendingActivity() const override;
DECLARE_VIRTUAL_TRACE();
« no previous file with comments | « Source/modules/netinfo/NetworkInformation.h ('k') | Source/modules/permissions/PermissionController.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698