Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Unified Diff: Source/modules/mediastream/RTCPeerConnection.h

Issue 1227783004: Fix virtual/override/final usage in Source/modules/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/mediastream/RTCPeerConnection.h
diff --git a/Source/modules/mediastream/RTCPeerConnection.h b/Source/modules/mediastream/RTCPeerConnection.h
index 39530616abcd4c8e8db177ccd8bffdce14ac1dd2..ba53a6b985763e8f370a641c31af1407bd49239b 100644
--- a/Source/modules/mediastream/RTCPeerConnection.h
+++ b/Source/modules/mediastream/RTCPeerConnection.h
@@ -64,7 +64,7 @@ class RTCPeerConnection final
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(RTCPeerConnection);
public:
static RTCPeerConnection* create(ExecutionContext*, const Dictionary&, const Dictionary&, ExceptionState&);
- virtual ~RTCPeerConnection();
+ ~RTCPeerConnection() override;
void createOffer(RTCSessionDescriptionCallback*, RTCErrorCallback*, const Dictionary&, ExceptionState&);
@@ -120,27 +120,27 @@ public:
DEFINE_ATTRIBUTE_EVENT_LISTENER(datachannel);
// WebRTCPeerConnectionHandlerClient
- virtual void negotiationNeeded() override;
- virtual void didGenerateICECandidate(const WebRTCICECandidate&) override;
- virtual void didChangeSignalingState(SignalingState) override;
- virtual void didChangeICEGatheringState(ICEGatheringState) override;
- virtual void didChangeICEConnectionState(ICEConnectionState) override;
- virtual void didAddRemoteStream(const WebMediaStream&) override;
- virtual void didRemoveRemoteStream(const WebMediaStream&) override;
- virtual void didAddRemoteDataChannel(WebRTCDataChannelHandler*) override;
- virtual void releasePeerConnectionHandler() override;
- virtual void closePeerConnection() override;
+ void negotiationNeeded() override;
+ void didGenerateICECandidate(const WebRTCICECandidate&) override;
+ void didChangeSignalingState(SignalingState) override;
+ void didChangeICEGatheringState(ICEGatheringState) override;
+ void didChangeICEConnectionState(ICEConnectionState) override;
+ void didAddRemoteStream(const WebMediaStream&) override;
+ void didRemoveRemoteStream(const WebMediaStream&) override;
+ void didAddRemoteDataChannel(WebRTCDataChannelHandler*) override;
+ void releasePeerConnectionHandler() override;
+ void closePeerConnection() override;
// EventTarget
- virtual const AtomicString& interfaceName() const override;
- virtual ExecutionContext* executionContext() const override;
+ const AtomicString& interfaceName() const override;
+ ExecutionContext* executionContext() const override;
// ActiveDOMObject
- virtual void suspend() override;
- virtual void resume() override;
- virtual void stop() override;
+ void suspend() override;
+ void resume() override;
+ void stop() override;
// We keep the this object alive until either stopped or closed.
- virtual bool hasPendingActivity() const override
+ bool hasPendingActivity() const override
{
return !m_closed && !m_stopped;
}
« no previous file with comments | « Source/modules/mediastream/RTCIceCandidateEvent.h ('k') | Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698