Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2107)

Unified Diff: Source/modules/indexeddb/InspectorIndexedDBAgent.cpp

Issue 1227783004: Fix virtual/override/final usage in Source/modules/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/indexeddb/InspectorIndexedDBAgent.h ('k') | Source/modules/indexeddb/WebIDBCallbacksImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/indexeddb/InspectorIndexedDBAgent.cpp
diff --git a/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp b/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp
index 26969febaf6fcb9ecde6149cb6d9b8c375c32d58..dcc461a1e65bb4c366fcb9b0c22d5e3175a8e63f 100644
--- a/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp
+++ b/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp
@@ -94,14 +94,14 @@ public:
return adoptRef(new GetDatabaseNamesCallback(requestCallback, securityOrigin));
}
- virtual ~GetDatabaseNamesCallback() { }
+ ~GetDatabaseNamesCallback() override { }
- virtual bool operator==(const EventListener& other) override
+ bool operator==(const EventListener& other) override
{
return this == &other;
}
- virtual void handleEvent(ExecutionContext*, Event* event) override
+ void handleEvent(ExecutionContext*, Event* event) override
{
if (!m_requestCallback->isActive())
return;
@@ -154,14 +154,14 @@ public:
return adoptRef(new OpenDatabaseCallback(executableWithDatabase));
}
- virtual ~OpenDatabaseCallback() { }
+ ~OpenDatabaseCallback() override { }
- virtual bool operator==(const EventListener& other) override
+ bool operator==(const EventListener& other) override
{
return this == &other;
}
- virtual void handleEvent(ExecutionContext* context, Event* event) override
+ void handleEvent(ExecutionContext* context, Event* event) override
{
if (event->type() != EventTypeNames::success) {
m_executableWithDatabase->requestCallback()->sendFailure("Unexpected event type.");
@@ -263,9 +263,9 @@ public:
return adoptRef(new DatabaseLoader(scriptState, requestCallback));
}
- virtual ~DatabaseLoader() { }
+ ~DatabaseLoader() override { }
- virtual void execute(IDBDatabase* idbDatabase) override
+ void execute(IDBDatabase* idbDatabase) override
{
if (!requestCallback()->isActive())
return;
@@ -306,7 +306,7 @@ public:
m_requestCallback->sendSuccess(result);
}
- virtual RequestCallback* requestCallback() override { return m_requestCallback.get(); }
+ RequestCallback* requestCallback() override { return m_requestCallback.get(); }
private:
DatabaseLoader(ScriptState* scriptState, PassRefPtrWillBeRawPtr<RequestDatabaseCallback> requestCallback)
: ExecutableWithDatabase(scriptState)
@@ -394,14 +394,14 @@ public:
return adoptRef(new OpenCursorCallback(scriptState, requestCallback, skipCount, pageSize));
}
- virtual ~OpenCursorCallback() { }
+ ~OpenCursorCallback() override { }
- virtual bool operator==(const EventListener& other) override
+ bool operator==(const EventListener& other) override
{
return this == &other;
}
- virtual void handleEvent(ExecutionContext*, Event* event) override
+ void handleEvent(ExecutionContext*, Event* event) override
{
if (event->type() != EventTypeNames::success) {
m_requestCallback->sendFailure("Unexpected event type.");
@@ -498,9 +498,9 @@ public:
return adoptRef(new DataLoader(scriptState, requestCallback, objectStoreName, indexName, idbKeyRange, skipCount, pageSize));
}
- virtual ~DataLoader() { }
+ ~DataLoader() override { }
- virtual void execute(IDBDatabase* idbDatabase) override
+ void execute(IDBDatabase* idbDatabase) override
{
if (!requestCallback()->isActive())
return;
@@ -532,7 +532,7 @@ public:
idbRequest->addEventListener(EventTypeNames::success, openCursorCallback, false);
}
- virtual RequestCallback* requestCallback() override { return m_requestCallback.get(); }
+ RequestCallback* requestCallback() override { return m_requestCallback.get(); }
DataLoader(ScriptState* scriptState, PassRefPtrWillBeRawPtr<RequestDataCallback> requestCallback, const String& objectStoreName, const String& indexName, IDBKeyRange* idbKeyRange, int skipCount, unsigned pageSize)
: ExecutableWithDatabase(scriptState)
, m_requestCallback(requestCallback)
@@ -692,14 +692,14 @@ public:
return adoptRef(new ClearObjectStoreListener(requestCallback));
}
- virtual ~ClearObjectStoreListener() { }
+ ~ClearObjectStoreListener() override { }
- virtual bool operator==(const EventListener& other) override
+ bool operator==(const EventListener& other) override
{
return this == &other;
}
- virtual void handleEvent(ExecutionContext*, Event* event) override
+ void handleEvent(ExecutionContext*, Event* event) override
{
if (!m_requestCallback->isActive())
return;
@@ -735,7 +735,7 @@ public:
{
}
- virtual void execute(IDBDatabase* idbDatabase) override
+ void execute(IDBDatabase* idbDatabase) override
{
if (!requestCallback()->isActive())
return;
@@ -761,7 +761,7 @@ public:
idbTransaction->addEventListener(EventTypeNames::complete, ClearObjectStoreListener::create(m_requestCallback), false);
}
- virtual RequestCallback* requestCallback() override { return m_requestCallback.get(); }
+ RequestCallback* requestCallback() override { return m_requestCallback.get(); }
private:
const String m_objectStoreName;
RefPtrWillBePersistent<ClearObjectStoreCallback> m_requestCallback;
« no previous file with comments | « Source/modules/indexeddb/InspectorIndexedDBAgent.h ('k') | Source/modules/indexeddb/WebIDBCallbacksImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698