Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1901)

Unified Diff: Source/modules/indexeddb/IDBRequest.h

Issue 1227783004: Fix virtual/override/final usage in Source/modules/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/indexeddb/IDBOpenDBRequest.h ('k') | Source/modules/indexeddb/IDBRequestTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/indexeddb/IDBRequest.h
diff --git a/Source/modules/indexeddb/IDBRequest.h b/Source/modules/indexeddb/IDBRequest.h
index 8848943cad65e48eb17abae793f93efc4d371f78..5dceb8f8f2708a8282d7ef90911056ef025f5e07 100644
--- a/Source/modules/indexeddb/IDBRequest.h
+++ b/Source/modules/indexeddb/IDBRequest.h
@@ -62,7 +62,7 @@ class MODULES_EXPORT IDBRequest
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(IDBRequest);
public:
static IDBRequest* create(ScriptState*, IDBAny* source, IDBTransaction*);
- virtual ~IDBRequest();
+ ~IDBRequest() override;
DECLARE_VIRTUAL_TRACE();
ScriptState* scriptState() { return m_scriptState.get(); }
@@ -110,16 +110,16 @@ public:
virtual void onSuccess(PassOwnPtr<WebIDBDatabase>, const IDBDatabaseMetadata&) { ASSERT_NOT_REACHED(); }
// ActiveDOMObject
- virtual bool hasPendingActivity() const override final;
- virtual void stop() override final;
+ bool hasPendingActivity() const final;
+ void stop() final;
// EventTarget
- virtual const AtomicString& interfaceName() const override;
- virtual ExecutionContext* executionContext() const override final;
- virtual void uncaughtExceptionInEventHandler() override final;
+ const AtomicString& interfaceName() const override;
+ ExecutionContext* executionContext() const final;
+ void uncaughtExceptionInEventHandler() final;
using EventTarget::dispatchEvent;
- virtual bool dispatchEvent(PassRefPtrWillBeRawPtr<Event>) override;
+ bool dispatchEvent(PassRefPtrWillBeRawPtr<Event>) override;
// Called by a version change transaction that has finished to set this
// request back from DONE (following "upgradeneeded") back to PENDING (for
« no previous file with comments | « Source/modules/indexeddb/IDBOpenDBRequest.h ('k') | Source/modules/indexeddb/IDBRequestTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698