Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2417)

Unified Diff: Source/modules/indexeddb/IDBOpenDBRequest.h

Issue 1227783004: Fix virtual/override/final usage in Source/modules/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/indexeddb/IDBObjectStore.cpp ('k') | Source/modules/indexeddb/IDBRequest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/indexeddb/IDBOpenDBRequest.h
diff --git a/Source/modules/indexeddb/IDBOpenDBRequest.h b/Source/modules/indexeddb/IDBOpenDBRequest.h
index e0b0e90a07e1c8c8a5f2363e4add49aab7974020..b460ab723ed5a2ce8bd0578f386a2b05ef1a70a1 100644
--- a/Source/modules/indexeddb/IDBOpenDBRequest.h
+++ b/Source/modules/indexeddb/IDBOpenDBRequest.h
@@ -38,25 +38,25 @@ class MODULES_EXPORT IDBOpenDBRequest final : public IDBRequest {
DEFINE_WRAPPERTYPEINFO();
public:
static IDBOpenDBRequest* create(ScriptState*, IDBDatabaseCallbacks*, int64_t transactionId, int64_t version);
- virtual ~IDBOpenDBRequest();
+ ~IDBOpenDBRequest() override;
DECLARE_VIRTUAL_TRACE();
using IDBRequest::onSuccess;
- virtual void onBlocked(int64_t existingVersion) override;
- virtual void onUpgradeNeeded(int64_t oldVersion, PassOwnPtr<WebIDBDatabase>, const IDBDatabaseMetadata&, WebIDBDataLoss, String dataLossMessage) override;
- virtual void onSuccess(PassOwnPtr<WebIDBDatabase>, const IDBDatabaseMetadata&) override;
- virtual void onSuccess(int64_t oldVersion) override;
+ void onBlocked(int64_t existingVersion) override;
+ void onUpgradeNeeded(int64_t oldVersion, PassOwnPtr<WebIDBDatabase>, const IDBDatabaseMetadata&, WebIDBDataLoss, String dataLossMessage) override;
+ void onSuccess(PassOwnPtr<WebIDBDatabase>, const IDBDatabaseMetadata&) override;
+ void onSuccess(int64_t oldVersion) override;
// EventTarget
- virtual const AtomicString& interfaceName() const override;
- virtual bool dispatchEvent(PassRefPtrWillBeRawPtr<Event>) override;
+ const AtomicString& interfaceName() const override;
+ bool dispatchEvent(PassRefPtrWillBeRawPtr<Event>) override;
DEFINE_ATTRIBUTE_EVENT_LISTENER(blocked);
DEFINE_ATTRIBUTE_EVENT_LISTENER(upgradeneeded);
protected:
- virtual bool shouldEnqueueEvent() const override;
+ bool shouldEnqueueEvent() const override;
private:
IDBOpenDBRequest(ScriptState*, IDBDatabaseCallbacks*, int64_t transactionId, int64_t version);
« no previous file with comments | « Source/modules/indexeddb/IDBObjectStore.cpp ('k') | Source/modules/indexeddb/IDBRequest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698