Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1008)

Unified Diff: Source/modules/filesystem/FileSystemCallbacks.h

Issue 1227783004: Fix virtual/override/final usage in Source/modules/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/filesystem/FileEntrySync.h ('k') | Source/modules/filesystem/FileWriter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/filesystem/FileSystemCallbacks.h
diff --git a/Source/modules/filesystem/FileSystemCallbacks.h b/Source/modules/filesystem/FileSystemCallbacks.h
index 6fd4dd4841b5a2ec558407bde52fd79cb5006560..ebb7dcb85e91a655ca8ee8d0ce5e6a716a14e564 100644
--- a/Source/modules/filesystem/FileSystemCallbacks.h
+++ b/Source/modules/filesystem/FileSystemCallbacks.h
@@ -55,10 +55,10 @@ class VoidCallback;
class FileSystemCallbacksBase : public AsyncFileSystemCallbacks {
public:
- virtual ~FileSystemCallbacksBase();
+ ~FileSystemCallbacksBase() override;
// For ErrorCallback.
- virtual void didFail(int code) override final;
+ void didFail(int code) final;
// Other callback methods are implemented by each subclass.
@@ -84,7 +84,7 @@ protected:
class EntryCallbacks final : public FileSystemCallbacksBase {
public:
static PassOwnPtr<AsyncFileSystemCallbacks> create(EntryCallback*, ErrorCallback*, ExecutionContext*, DOMFileSystemBase*, const String& expectedPath, bool isDirectory);
- virtual void didSucceed() override;
+ void didSucceed() override;
private:
EntryCallbacks(EntryCallback*, ErrorCallback*, ExecutionContext*, DOMFileSystemBase*, const String& expectedPath, bool isDirectory);
@@ -96,8 +96,8 @@ private:
class EntriesCallbacks final : public FileSystemCallbacksBase {
public:
static PassOwnPtr<AsyncFileSystemCallbacks> create(EntriesCallback*, ErrorCallback*, ExecutionContext*, DirectoryReaderBase*, const String& basePath);
- virtual void didReadDirectoryEntry(const String& name, bool isDirectory) override;
- virtual void didReadDirectoryEntries(bool hasMore) override;
+ void didReadDirectoryEntry(const String& name, bool isDirectory) override;
+ void didReadDirectoryEntries(bool hasMore) override;
private:
EntriesCallbacks(EntriesCallback*, ErrorCallback*, ExecutionContext*, DirectoryReaderBase*, const String& basePath);
@@ -110,7 +110,7 @@ private:
class FileSystemCallbacks final : public FileSystemCallbacksBase {
public:
static PassOwnPtr<AsyncFileSystemCallbacks> create(FileSystemCallback*, ErrorCallback*, ExecutionContext*, FileSystemType);
- virtual void didOpenFileSystem(const String& name, const KURL& rootURL) override;
+ void didOpenFileSystem(const String& name, const KURL& rootURL) override;
private:
FileSystemCallbacks(FileSystemCallback*, ErrorCallback*, ExecutionContext*, FileSystemType);
@@ -121,7 +121,7 @@ private:
class ResolveURICallbacks final : public FileSystemCallbacksBase {
public:
static PassOwnPtr<AsyncFileSystemCallbacks> create(EntryCallback*, ErrorCallback*, ExecutionContext*);
- virtual void didResolveURL(const String& name, const KURL& rootURL, FileSystemType, const String& filePath, bool isDirectry) override;
+ void didResolveURL(const String& name, const KURL& rootURL, FileSystemType, const String& filePath, bool isDirectry) override;
private:
ResolveURICallbacks(EntryCallback*, ErrorCallback*, ExecutionContext*);
@@ -131,7 +131,7 @@ private:
class MetadataCallbacks final : public FileSystemCallbacksBase {
public:
static PassOwnPtr<AsyncFileSystemCallbacks> create(MetadataCallback*, ErrorCallback*, ExecutionContext*, DOMFileSystemBase*);
- virtual void didReadMetadata(const FileMetadata&) override;
+ void didReadMetadata(const FileMetadata&) override;
private:
MetadataCallbacks(MetadataCallback*, ErrorCallback*, ExecutionContext*, DOMFileSystemBase*);
@@ -141,7 +141,7 @@ private:
class FileWriterBaseCallbacks final : public FileSystemCallbacksBase {
public:
static PassOwnPtr<AsyncFileSystemCallbacks> create(FileWriterBase*, FileWriterBaseCallback*, ErrorCallback*, ExecutionContext*);
- virtual void didCreateFileWriter(PassOwnPtr<WebFileWriter>, long long length) override;
+ void didCreateFileWriter(PassOwnPtr<WebFileWriter>, long long length) override;
private:
FileWriterBaseCallbacks(FileWriterBase*, FileWriterBaseCallback*, ErrorCallback*, ExecutionContext*);
@@ -164,7 +164,7 @@ private:
class VoidCallbacks final : public FileSystemCallbacksBase {
public:
static PassOwnPtr<AsyncFileSystemCallbacks> create(VoidCallback*, ErrorCallback*, ExecutionContext*, DOMFileSystemBase*);
- virtual void didSucceed() override;
+ void didSucceed() override;
private:
VoidCallbacks(VoidCallback*, ErrorCallback*, ExecutionContext*, DOMFileSystemBase*);
« no previous file with comments | « Source/modules/filesystem/FileEntrySync.h ('k') | Source/modules/filesystem/FileWriter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698