Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1613)

Unified Diff: Source/modules/filesystem/DOMFileSystemSync.cpp

Issue 1227783004: Fix virtual/override/final usage in Source/modules/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/filesystem/DOMFileSystemSync.h ('k') | Source/modules/filesystem/DirectoryEntry.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/filesystem/DOMFileSystemSync.cpp
diff --git a/Source/modules/filesystem/DOMFileSystemSync.cpp b/Source/modules/filesystem/DOMFileSystemSync.cpp
index cb98d5c920689179e9e2a8f4ee58fe5518e4804b..d930a8a34545840a1c73416fff4251796c7ae3e6 100644
--- a/Source/modules/filesystem/DOMFileSystemSync.cpp
+++ b/Source/modules/filesystem/DOMFileSystemSync.cpp
@@ -108,17 +108,17 @@ public:
return adoptPtr(static_cast<AsyncFileSystemCallbacks*>(new CreateFileHelper(result, name, url, type)));
}
- virtual void didFail(int code) override
+ void didFail(int code) override
{
m_result->m_failed = true;
m_result->m_code = code;
}
- virtual ~CreateFileHelper()
+ ~CreateFileHelper() override
{
}
- virtual void didCreateSnapshotFile(const FileMetadata& metadata, PassRefPtr<BlobDataHandle> snapshot) override
+ void didCreateSnapshotFile(const FileMetadata& metadata, PassRefPtr<BlobDataHandle> snapshot) override
{
// We can't directly use the snapshot blob data handle because the content type on it hasn't been set.
// The |snapshot| param is here to provide a a chain of custody thru thread bridging that is held onto until
@@ -128,7 +128,7 @@ public:
m_result->m_file = DOMFileSystemBase::createFile(metadata, m_url, m_type, m_name);
}
- virtual bool shouldBlockUntilCompletion() const override
+ bool shouldBlockUntilCompletion() const override
{
return true;
}
@@ -171,7 +171,7 @@ public:
return new ReceiveFileWriterCallback();
}
- virtual void handleEvent(FileWriterBase*) override
+ void handleEvent(FileWriterBase*) override
{
}
@@ -188,7 +188,7 @@ public:
return new LocalErrorCallback(errorCode);
}
- virtual void handleEvent(FileError* error) override
+ void handleEvent(FileError* error) override
{
ASSERT(error->code() != FileError::OK);
m_errorCode = error->code();
« no previous file with comments | « Source/modules/filesystem/DOMFileSystemSync.h ('k') | Source/modules/filesystem/DirectoryEntry.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698