Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1221)

Unified Diff: Source/modules/credentialmanager/CredentialsContainer.cpp

Issue 1227783004: Fix virtual/override/final usage in Source/modules/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/compositorworker/CompositorWorkerThread.h ('k') | Source/modules/crypto/CryptoResultImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/credentialmanager/CredentialsContainer.cpp
diff --git a/Source/modules/credentialmanager/CredentialsContainer.cpp b/Source/modules/credentialmanager/CredentialsContainer.cpp
index c0c18863ccca36bf4da87803e96f27a2dff220c5..8ab3b2926cc4e40c901314f23bcd740e1f3e8f5a 100644
--- a/Source/modules/credentialmanager/CredentialsContainer.cpp
+++ b/Source/modules/credentialmanager/CredentialsContainer.cpp
@@ -44,14 +44,14 @@ class NotificationCallbacks : public WebCredentialManagerClient::NotificationCal
WTF_MAKE_NONCOPYABLE(NotificationCallbacks);
public:
explicit NotificationCallbacks(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver) : m_resolver(resolver) { }
- virtual ~NotificationCallbacks() { }
+ ~NotificationCallbacks() override { }
- virtual void onSuccess() override
+ void onSuccess() override
{
m_resolver->resolve();
}
- virtual void onError(WebCredentialManagerError* reason) override
+ void onError(WebCredentialManagerError* reason) override
{
rejectDueToCredentialManagerError(m_resolver, reason);
}
@@ -64,9 +64,9 @@ class RequestCallbacks : public WebCredentialManagerClient::RequestCallbacks {
WTF_MAKE_NONCOPYABLE(RequestCallbacks);
public:
explicit RequestCallbacks(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver) : m_resolver(resolver) { }
- virtual ~RequestCallbacks() { }
+ ~RequestCallbacks() override { }
- virtual void onSuccess(WebCredential* credential) override
+ void onSuccess(WebCredential* credential) override
{
if (!credential) {
m_resolver->resolve();
@@ -80,7 +80,7 @@ public:
m_resolver->resolve(FederatedCredential::create(static_cast<WebFederatedCredential*>(credential)));
}
- virtual void onError(WebCredentialManagerError* reason) override
+ void onError(WebCredentialManagerError* reason) override
{
rejectDueToCredentialManagerError(m_resolver, reason);
}
« no previous file with comments | « Source/modules/compositorworker/CompositorWorkerThread.h ('k') | Source/modules/crypto/CryptoResultImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698