Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1836)

Unified Diff: Source/modules/cachestorage/Cache.cpp

Issue 1227783004: Fix virtual/override/final usage in Source/modules/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/battery/BatteryManager.h ('k') | Source/modules/cachestorage/CacheStorage.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/cachestorage/Cache.cpp
diff --git a/Source/modules/cachestorage/Cache.cpp b/Source/modules/cachestorage/Cache.cpp
index f5abc013831d6633d0e0ba6bd6ac0a48789742ae..fff953336d27cb52a1f951a42b60fdd9ad655cf1 100644
--- a/Source/modules/cachestorage/Cache.cpp
+++ b/Source/modules/cachestorage/Cache.cpp
@@ -33,14 +33,14 @@ public:
CacheMatchCallbacks(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
: m_resolver(resolver) { }
- virtual void onSuccess(WebServiceWorkerResponse* webResponse) override
+ void onSuccess(WebServiceWorkerResponse* webResponse) override
{
m_resolver->resolve(Response::create(m_resolver->scriptState()->executionContext(), *webResponse));
m_resolver.clear();
}
// Ownership of |rawReason| must be passed.
- virtual void onError(WebServiceWorkerCacheError* rawReason) override
+ void onError(WebServiceWorkerCacheError* rawReason) override
{
OwnPtr<WebServiceWorkerCacheError> reason = adoptPtr(rawReason);
if (*reason == WebServiceWorkerCacheErrorNotFound)
@@ -61,7 +61,7 @@ public:
CacheWithResponsesCallbacks(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
: m_resolver(resolver) { }
- virtual void onSuccess(WebVector<WebServiceWorkerResponse>* webResponses) override
+ void onSuccess(WebVector<WebServiceWorkerResponse>* webResponses) override
{
HeapVector<Member<Response>> responses;
for (size_t i = 0; i < webResponses->size(); ++i)
@@ -71,7 +71,7 @@ public:
}
// Ownership of |rawReason| must be passed.
- virtual void onError(WebServiceWorkerCacheError* rawReason) override
+ void onError(WebServiceWorkerCacheError* rawReason) override
{
OwnPtr<WebServiceWorkerCacheError> reason = adoptPtr(rawReason);
m_resolver->reject(CacheStorageError::createException(*reason));
@@ -96,7 +96,7 @@ public:
}
// Ownership of |rawReason| must be passed.
- virtual void onError(WebServiceWorkerCacheError* rawReason) override
+ void onError(WebServiceWorkerCacheError* rawReason) override
{
OwnPtr<WebServiceWorkerCacheError> reason = adoptPtr(rawReason);
if (*reason == WebServiceWorkerCacheErrorNotFound)
@@ -117,7 +117,7 @@ public:
CacheWithRequestsCallbacks(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
: m_resolver(resolver) { }
- virtual void onSuccess(WebVector<WebServiceWorkerRequest>* webRequests) override
+ void onSuccess(WebVector<WebServiceWorkerRequest>* webRequests) override
{
HeapVector<Member<Request>> requests;
for (size_t i = 0; i < webRequests->size(); ++i)
@@ -127,7 +127,7 @@ public:
}
// Ownership of |rawReason| must be passed.
- virtual void onError(WebServiceWorkerCacheError* rawReason) override
+ void onError(WebServiceWorkerCacheError* rawReason) override
{
OwnPtr<WebServiceWorkerCacheError> reason = adoptPtr(rawReason);
m_resolver->reject(CacheStorageError::createException(*reason));
« no previous file with comments | « Source/modules/battery/BatteryManager.h ('k') | Source/modules/cachestorage/CacheStorage.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698