Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Unified Diff: Source/modules/accessibility/AXSpinButton.h

Issue 1227783004: Fix virtual/override/final usage in Source/modules/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/accessibility/AXSlider.h ('k') | Source/modules/accessibility/AXTable.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXSpinButton.h
diff --git a/Source/modules/accessibility/AXSpinButton.h b/Source/modules/accessibility/AXSpinButton.h
index 338d9dab4a94d1f27b21bcfec62b4e92da51d51a..ac7019e186ba72b89410aa783c04e251a47d27ee 100644
--- a/Source/modules/accessibility/AXSpinButton.h
+++ b/Source/modules/accessibility/AXSpinButton.h
@@ -37,7 +37,7 @@ class AXObjectCacheImpl;
class AXSpinButton final : public AXMockObject {
public:
static PassRefPtrWillBeRawPtr<AXSpinButton> create(AXObjectCacheImpl&);
- virtual ~AXSpinButton();
+ ~AXSpinButton() override;
DECLARE_VIRTUAL_TRACE();
void setSpinButtonElement(SpinButtonElement* spinButton) { m_spinButtonElement = spinButton; }
@@ -46,13 +46,13 @@ public:
private:
explicit AXSpinButton(AXObjectCacheImpl&);
- virtual AccessibilityRole roleValue() const override;
- virtual bool isSpinButton() const override { return true; }
- virtual bool isNativeSpinButton() const override { return true; }
- virtual void addChildren() override;
- virtual LayoutRect elementRect() const override;
- virtual void detach() override;
- virtual void detachFromParent() override;
+ AccessibilityRole roleValue() const override;
+ bool isSpinButton() const override { return true; }
+ bool isNativeSpinButton() const override { return true; }
+ void addChildren() override;
+ LayoutRect elementRect() const override;
+ void detach() override;
+ void detachFromParent() override;
RawPtrWillBeMember<SpinButtonElement> m_spinButtonElement;
};
@@ -60,7 +60,7 @@ private:
class AXSpinButtonPart final : public AXMockObject {
public:
static PassRefPtrWillBeRawPtr<AXSpinButtonPart> create(AXObjectCacheImpl&);
- virtual ~AXSpinButtonPart() { }
+ ~AXSpinButtonPart() override { }
bool isIncrementor() const { return m_isIncrementor; }
void setIsIncrementor(bool value) { m_isIncrementor = value; }
@@ -69,10 +69,10 @@ private:
explicit AXSpinButtonPart(AXObjectCacheImpl&);
bool m_isIncrementor : 1;
- virtual bool press() const override;
- virtual AccessibilityRole roleValue() const override { return ButtonRole; }
- virtual bool isSpinButtonPart() const override { return true; }
- virtual LayoutRect elementRect() const override;
+ bool press() const override;
+ AccessibilityRole roleValue() const override { return ButtonRole; }
+ bool isSpinButtonPart() const override { return true; }
+ LayoutRect elementRect() const override;
};
DEFINE_AX_OBJECT_TYPE_CASTS(AXSpinButton, isNativeSpinButton());
« no previous file with comments | « Source/modules/accessibility/AXSlider.h ('k') | Source/modules/accessibility/AXTable.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698