Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2034)

Unified Diff: Source/modules/accessibility/AXMediaControls.h

Issue 1227783004: Fix virtual/override/final usage in Source/modules/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/accessibility/AXListBoxOption.h ('k') | Source/modules/accessibility/AXMenuList.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXMediaControls.h
diff --git a/Source/modules/accessibility/AXMediaControls.h b/Source/modules/accessibility/AXMediaControls.h
index 212aac0cb949f7c515e3047c18afdf63f9324077..f30d27847f54b60f0d522c0a0c9f4c6ff0c6a02c 100644
--- a/Source/modules/accessibility/AXMediaControls.h
+++ b/Source/modules/accessibility/AXMediaControls.h
@@ -41,18 +41,18 @@ class AccessibilityMediaControl : public AXLayoutObject {
public:
static PassRefPtrWillBeRawPtr<AXObject> create(LayoutObject*, AXObjectCacheImpl&);
- virtual ~AccessibilityMediaControl() { }
+ ~AccessibilityMediaControl() override { }
- virtual AccessibilityRole roleValue() const override;
+ AccessibilityRole roleValue() const override;
- virtual String deprecatedTitle(TextUnderElementMode) const override final;
- virtual String deprecatedAccessibilityDescription() const override;
- virtual String deprecatedHelpText() const override;
+ String deprecatedTitle(TextUnderElementMode) const final;
+ String deprecatedAccessibilityDescription() const override;
+ String deprecatedHelpText() const override;
protected:
AccessibilityMediaControl(LayoutObject*, AXObjectCacheImpl&);
MediaControlElementType controlType() const;
- virtual bool computeAccessibilityIsIgnored(IgnoredReasons* = nullptr) const override;
+ bool computeAccessibilityIsIgnored(IgnoredReasons* = nullptr) const override;
};
@@ -60,10 +60,10 @@ class AccessibilityMediaTimeline final : public AXSlider {
public:
static PassRefPtrWillBeRawPtr<AXObject> create(LayoutObject*, AXObjectCacheImpl&);
- virtual ~AccessibilityMediaTimeline() { }
+ ~AccessibilityMediaTimeline() override { }
- virtual String deprecatedHelpText() const override;
- virtual String valueDescription() const override;
+ String deprecatedHelpText() const override;
+ String valueDescription() const override;
const AtomicString& getAttribute(const QualifiedName& attribute) const;
private:
@@ -75,17 +75,17 @@ class AXMediaControlsContainer final : public AccessibilityMediaControl {
public:
static PassRefPtrWillBeRawPtr<AXObject> create(LayoutObject*, AXObjectCacheImpl&);
- virtual ~AXMediaControlsContainer() { }
+ ~AXMediaControlsContainer() override { }
- virtual AccessibilityRole roleValue() const override { return ToolbarRole; }
+ AccessibilityRole roleValue() const override { return ToolbarRole; }
- virtual String deprecatedHelpText() const override;
- virtual String deprecatedAccessibilityDescription() const override;
+ String deprecatedHelpText() const override;
+ String deprecatedAccessibilityDescription() const override;
private:
AXMediaControlsContainer(LayoutObject*, AXObjectCacheImpl&);
bool controllingVideoElement() const;
- virtual bool computeAccessibilityIsIgnored(IgnoredReasons* = nullptr) const override;
+ bool computeAccessibilityIsIgnored(IgnoredReasons* = nullptr) const override;
};
@@ -93,16 +93,16 @@ class AccessibilityMediaTimeDisplay final : public AccessibilityMediaControl {
public:
static PassRefPtrWillBeRawPtr<AXObject> create(LayoutObject*, AXObjectCacheImpl&);
- virtual ~AccessibilityMediaTimeDisplay() { }
+ ~AccessibilityMediaTimeDisplay() override { }
- virtual AccessibilityRole roleValue() const override { return StaticTextRole; }
+ AccessibilityRole roleValue() const override { return StaticTextRole; }
- virtual String stringValue() const override;
- virtual String deprecatedAccessibilityDescription() const override;
+ String stringValue() const override;
+ String deprecatedAccessibilityDescription() const override;
private:
AccessibilityMediaTimeDisplay(LayoutObject*, AXObjectCacheImpl&);
- virtual bool computeAccessibilityIsIgnored(IgnoredReasons* = nullptr) const override;
+ bool computeAccessibilityIsIgnored(IgnoredReasons* = nullptr) const override;
};
« no previous file with comments | « Source/modules/accessibility/AXListBoxOption.h ('k') | Source/modules/accessibility/AXMenuList.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698