Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Side by Side Diff: Source/modules/websockets/DocumentWebSocketChannel.cpp

Issue 1227783004: Fix virtual/override/final usage in Source/modules/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 #include "public/platform/WebURL.h" 57 #include "public/platform/WebURL.h"
58 #include "public/platform/WebVector.h" 58 #include "public/platform/WebVector.h"
59 59
60 using blink::WebSocketHandle; 60 using blink::WebSocketHandle;
61 61
62 namespace blink { 62 namespace blink {
63 63
64 class DocumentWebSocketChannel::BlobLoader final : public GarbageCollectedFinali zed<DocumentWebSocketChannel::BlobLoader>, public FileReaderLoaderClient { 64 class DocumentWebSocketChannel::BlobLoader final : public GarbageCollectedFinali zed<DocumentWebSocketChannel::BlobLoader>, public FileReaderLoaderClient {
65 public: 65 public:
66 BlobLoader(PassRefPtr<BlobDataHandle>, DocumentWebSocketChannel*); 66 BlobLoader(PassRefPtr<BlobDataHandle>, DocumentWebSocketChannel*);
67 virtual ~BlobLoader() { } 67 ~BlobLoader() override { }
68 68
69 void cancel(); 69 void cancel();
70 70
71 // FileReaderLoaderClient functions. 71 // FileReaderLoaderClient functions.
72 virtual void didStartLoading() override { } 72 void didStartLoading() override { }
73 virtual void didReceiveData() override { } 73 void didReceiveData() override { }
74 virtual void didFinishLoading() override; 74 void didFinishLoading() override;
75 virtual void didFail(FileError::ErrorCode) override; 75 void didFail(FileError::ErrorCode) override;
76 76
77 DEFINE_INLINE_TRACE() 77 DEFINE_INLINE_TRACE()
78 { 78 {
79 visitor->trace(m_channel); 79 visitor->trace(m_channel);
80 } 80 }
81 81
82 private: 82 private:
83 Member<DocumentWebSocketChannel> m_channel; 83 Member<DocumentWebSocketChannel> m_channel;
84 FileReaderLoader m_loader; 84 FileReaderLoader m_loader;
85 }; 85 };
(...skipping 490 matching lines...) Expand 10 before | Expand all | Expand 10 after
576 576
577 DEFINE_TRACE(DocumentWebSocketChannel) 577 DEFINE_TRACE(DocumentWebSocketChannel)
578 { 578 {
579 visitor->trace(m_blobLoader); 579 visitor->trace(m_blobLoader);
580 visitor->trace(m_client); 580 visitor->trace(m_client);
581 WebSocketChannel::trace(visitor); 581 WebSocketChannel::trace(visitor);
582 ContextLifecycleObserver::trace(visitor); 582 ContextLifecycleObserver::trace(visitor);
583 } 583 }
584 584
585 } // namespace blink 585 } // namespace blink
OLDNEW
« no previous file with comments | « Source/modules/websockets/DocumentWebSocketChannel.h ('k') | Source/modules/websockets/DocumentWebSocketChannelTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698