Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: Source/modules/webgl/WebGLSharedObject.h

Issue 1227783004: Fix virtual/override/final usage in Source/modules/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 19 matching lines...) Expand all
30 30
31 namespace blink { 31 namespace blink {
32 32
33 class WebGLContextGroup; 33 class WebGLContextGroup;
34 class WebGLRenderingContextBase; 34 class WebGLRenderingContextBase;
35 35
36 // WebGLSharedObject the base class for objects that can be shared by multiple 36 // WebGLSharedObject the base class for objects that can be shared by multiple
37 // WebGLRenderingContexts. 37 // WebGLRenderingContexts.
38 class WebGLSharedObject : public WebGLObject { 38 class WebGLSharedObject : public WebGLObject {
39 public: 39 public:
40 virtual ~WebGLSharedObject(); 40 ~WebGLSharedObject() override;
41 41
42 WebGLContextGroup* contextGroup() const { return m_contextGroup; } 42 WebGLContextGroup* contextGroup() const { return m_contextGroup; }
43 43
44 virtual bool isBuffer() const { return false; } 44 virtual bool isBuffer() const { return false; }
45 virtual bool isProgram() const { return false; } 45 virtual bool isProgram() const { return false; }
46 virtual bool isQuery() const { return false; } 46 virtual bool isQuery() const { return false; }
47 virtual bool isRenderbuffer() const { return false; } 47 virtual bool isRenderbuffer() const { return false; }
48 virtual bool isSampler() const { return false; } 48 virtual bool isSampler() const { return false; }
49 virtual bool isShader() const { return false; } 49 virtual bool isShader() const { return false; }
50 virtual bool isSync() const { return false; } 50 virtual bool isSync() const { return false; }
51 virtual bool isTexture() const { return false; } 51 virtual bool isTexture() const { return false; }
52 virtual bool isTransformFeedback() const { return false; } 52 virtual bool isTransformFeedback() const { return false; }
53 53
54 virtual bool validate(const WebGLContextGroup* contextGroup, const WebGLRend eringContextBase*) const override final 54 bool validate(const WebGLContextGroup* contextGroup, const WebGLRenderingCon textBase*) const final
55 { 55 {
56 return contextGroup == m_contextGroup; 56 return contextGroup == m_contextGroup;
57 } 57 }
58 58
59 void detachContextGroup(); 59 void detachContextGroup();
60 60
61 protected: 61 protected:
62 explicit WebGLSharedObject(WebGLRenderingContextBase*); 62 explicit WebGLSharedObject(WebGLRenderingContextBase*);
63 63
64 virtual bool hasGroupOrContext() const override final 64 bool hasGroupOrContext() const final
65 { 65 {
66 return m_contextGroup; 66 return m_contextGroup;
67 } 67 }
68 68
69 virtual WebGraphicsContext3D* getAWebGraphicsContext3D() const override fina l; 69 WebGraphicsContext3D* getAWebGraphicsContext3D() const final;
70 70
71 private: 71 private:
72 WebGLContextGroup* m_contextGroup; 72 WebGLContextGroup* m_contextGroup;
73 }; 73 };
74 74
75 } // namespace blink 75 } // namespace blink
76 76
77 #endif // WebGLSharedObject_h 77 #endif // WebGLSharedObject_h
OLDNEW
« no previous file with comments | « Source/modules/webgl/WebGLRenderingContextBase.cpp ('k') | Source/modules/webgl/WebGLVertexArrayObjectBase.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698