Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: Source/modules/webgl/WebGLContextObject.h

Issue 1227783004: Fix virtual/override/final usage in Source/modules/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/modules/webgl/WebGLContextEvent.h ('k') | Source/modules/webgl/WebGLDebugRendererInfo.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 22 matching lines...) Expand all
33 } 33 }
34 34
35 namespace blink { 35 namespace blink {
36 36
37 class WebGLRenderingContextBase; 37 class WebGLRenderingContextBase;
38 38
39 // WebGLContextObject the base class for objects that are owned by a specific 39 // WebGLContextObject the base class for objects that are owned by a specific
40 // WebGLRenderingContextBase. 40 // WebGLRenderingContextBase.
41 class WebGLContextObject : public WebGLObject { 41 class WebGLContextObject : public WebGLObject {
42 public: 42 public:
43 virtual ~WebGLContextObject(); 43 ~WebGLContextObject() override;
44 44
45 WebGLRenderingContextBase* context() const { return m_context; } 45 WebGLRenderingContextBase* context() const { return m_context; }
46 46
47 virtual bool validate(const WebGLContextGroup*, const WebGLRenderingContextB ase* context) const override final 47 bool validate(const WebGLContextGroup*, const WebGLRenderingContextBase* con text) const final
48 { 48 {
49 return context == m_context; 49 return context == m_context;
50 } 50 }
51 51
52 void detachContext(); 52 void detachContext();
53 53
54 DECLARE_VIRTUAL_TRACE(); 54 DECLARE_VIRTUAL_TRACE();
55 55
56 protected: 56 protected:
57 explicit WebGLContextObject(WebGLRenderingContextBase*); 57 explicit WebGLContextObject(WebGLRenderingContextBase*);
58 58
59 virtual bool hasGroupOrContext() const override final 59 bool hasGroupOrContext() const final
60 { 60 {
61 return m_context; 61 return m_context;
62 } 62 }
63 63
64 virtual WebGraphicsContext3D* getAWebGraphicsContext3D() const override fina l; 64 WebGraphicsContext3D* getAWebGraphicsContext3D() const final;
65 65
66 private: 66 private:
67 RawPtrWillBeMember<WebGLRenderingContextBase> m_context; 67 RawPtrWillBeMember<WebGLRenderingContextBase> m_context;
68 }; 68 };
69 69
70 } // namespace blink 70 } // namespace blink
71 71
72 #endif // WebGLContextObject_h 72 #endif // WebGLContextObject_h
OLDNEW
« no previous file with comments | « Source/modules/webgl/WebGLContextEvent.h ('k') | Source/modules/webgl/WebGLDebugRendererInfo.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698