Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: Source/modules/storage/InspectorDOMStorageAgent.h

Issue 1227783004: Fix virtual/override/final usage in Source/modules/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 46
47 typedef String ErrorString; 47 typedef String ErrorString;
48 48
49 class MODULES_EXPORT InspectorDOMStorageAgent final : public InspectorBaseAgent< InspectorDOMStorageAgent, InspectorFrontend::DOMStorage>, public InspectorBacken dDispatcher::DOMStorageCommandHandler { 49 class MODULES_EXPORT InspectorDOMStorageAgent final : public InspectorBaseAgent< InspectorDOMStorageAgent, InspectorFrontend::DOMStorage>, public InspectorBacken dDispatcher::DOMStorageCommandHandler {
50 public: 50 public:
51 static PassOwnPtrWillBeRawPtr<InspectorDOMStorageAgent> create(Page* page) 51 static PassOwnPtrWillBeRawPtr<InspectorDOMStorageAgent> create(Page* page)
52 { 52 {
53 return adoptPtrWillBeNoop(new InspectorDOMStorageAgent(page)); 53 return adoptPtrWillBeNoop(new InspectorDOMStorageAgent(page));
54 } 54 }
55 55
56 virtual ~InspectorDOMStorageAgent(); 56 ~InspectorDOMStorageAgent() override;
57 DECLARE_VIRTUAL_TRACE(); 57 DECLARE_VIRTUAL_TRACE();
58 58
59 void didDispatchDOMStorageEvent(const String& key, const String& oldValue, c onst String& newValue, StorageType, SecurityOrigin*); 59 void didDispatchDOMStorageEvent(const String& key, const String& oldValue, c onst String& newValue, StorageType, SecurityOrigin*);
60 60
61 private: 61 private:
62 explicit InspectorDOMStorageAgent(Page*); 62 explicit InspectorDOMStorageAgent(Page*);
63 63
64 // InspectorBaseAgent overrides. 64 // InspectorBaseAgent overrides.
65 void disable(ErrorString*) override; 65 void disable(ErrorString*) override;
66 void restore() override; 66 void restore() override;
67 67
68 // InspectorBackendDispatcher::DOMStorageCommandHandler overrides. 68 // InspectorBackendDispatcher::DOMStorageCommandHandler overrides.
69 void enable(ErrorString*) override; 69 void enable(ErrorString*) override;
70 void getDOMStorageItems(ErrorString*, const RefPtr<JSONObject>& storageId, R efPtr<TypeBuilder::Array<TypeBuilder::Array<String>>>& items) override; 70 void getDOMStorageItems(ErrorString*, const RefPtr<JSONObject>& storageId, R efPtr<TypeBuilder::Array<TypeBuilder::Array<String>>>& items) override;
71 void setDOMStorageItem(ErrorString*, const RefPtr<JSONObject>& storageId, co nst String& key, const String& value) override; 71 void setDOMStorageItem(ErrorString*, const RefPtr<JSONObject>& storageId, co nst String& key, const String& value) override;
72 void removeDOMStorageItem(ErrorString*, const RefPtr<JSONObject>& storageId, const String& key) override; 72 void removeDOMStorageItem(ErrorString*, const RefPtr<JSONObject>& storageId, const String& key) override;
73 73
74 StorageArea* findStorageArea(ErrorString*, const RefPtr<JSONObject>&, LocalF rame*&); 74 StorageArea* findStorageArea(ErrorString*, const RefPtr<JSONObject>&, LocalF rame*&);
75 PassRefPtr<TypeBuilder::DOMStorage::StorageId> storageId(SecurityOrigin*, bo ol isLocalStorage); 75 PassRefPtr<TypeBuilder::DOMStorage::StorageId> storageId(SecurityOrigin*, bo ol isLocalStorage);
76 76
77 RawPtrWillBeMember<Page> m_page; 77 RawPtrWillBeMember<Page> m_page;
78 bool m_isEnabled; 78 bool m_isEnabled;
79 }; 79 };
80 80
81 } // namespace blink 81 } // namespace blink
82 82
83 #endif // !defined(InspectorDOMStorageAgent_h) 83 #endif // !defined(InspectorDOMStorageAgent_h)
OLDNEW
« no previous file with comments | « Source/modules/storage/DOMWindowStorageController.h ('k') | Source/modules/storage/StorageEvent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698