Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: Source/modules/geolocation/GeolocationController.h

Issue 1227783004: Fix virtual/override/final usage in Source/modules/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 void positionChanged(GeolocationPosition*); 57 void positionChanged(GeolocationPosition*);
58 void errorOccurred(GeolocationError*); 58 void errorOccurred(GeolocationError*);
59 59
60 GeolocationPosition* lastPosition(); 60 GeolocationPosition* lastPosition();
61 61
62 void setClientForTest(GeolocationClient*); 62 void setClientForTest(GeolocationClient*);
63 bool hasClientForTest() { return m_hasClientForTest; } 63 bool hasClientForTest() { return m_hasClientForTest; }
64 GeolocationClient* client() { return m_client; } 64 GeolocationClient* client() { return m_client; }
65 65
66 // Inherited from PageLifecycleObserver. 66 // Inherited from PageLifecycleObserver.
67 virtual void pageVisibilityChanged() override; 67 void pageVisibilityChanged() override;
68 68
69 static const char* supplementName(); 69 static const char* supplementName();
70 static GeolocationController* from(LocalFrame* frame) { return static_cast<G eolocationController*>(WillBeHeapSupplement<LocalFrame>::from(frame, supplementN ame())); } 70 static GeolocationController* from(LocalFrame* frame) { return static_cast<G eolocationController*>(WillBeHeapSupplement<LocalFrame>::from(frame, supplementN ame())); }
71 71
72 // Inherited from Supplement. 72 // Inherited from Supplement.
73 DECLARE_VIRTUAL_TRACE(); 73 DECLARE_VIRTUAL_TRACE();
74 74
75 private: 75 private:
76 GeolocationController(LocalFrame&, GeolocationClient*); 76 GeolocationController(LocalFrame&, GeolocationClient*);
77 77
78 void startUpdatingIfNeeded(); 78 void startUpdatingIfNeeded();
79 void stopUpdatingIfNeeded(); 79 void stopUpdatingIfNeeded();
80 80
81 RawPtrWillBeMember<GeolocationClient> m_client; 81 RawPtrWillBeMember<GeolocationClient> m_client;
82 bool m_hasClientForTest; 82 bool m_hasClientForTest;
83 83
84 PersistentWillBeMember<GeolocationPosition> m_lastPosition; 84 PersistentWillBeMember<GeolocationPosition> m_lastPosition;
85 typedef PersistentHeapHashSetWillBeHeapHashSet<Member<Geolocation>> Observer sSet; 85 typedef PersistentHeapHashSetWillBeHeapHashSet<Member<Geolocation>> Observer sSet;
86 // All observers; both those requesting high accuracy and those not. 86 // All observers; both those requesting high accuracy and those not.
87 ObserversSet m_observers; 87 ObserversSet m_observers;
88 ObserversSet m_highAccuracyObservers; 88 ObserversSet m_highAccuracyObservers;
89 bool m_isClientUpdating; 89 bool m_isClientUpdating;
90 }; 90 };
91 91
92 } // namespace blink 92 } // namespace blink
93 93
94 #endif // GeolocationController_h 94 #endif // GeolocationController_h
OLDNEW
« no previous file with comments | « Source/modules/geolocation/Geolocation.h ('k') | Source/modules/geolocation/testing/GeolocationClientMock.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698