Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: Source/modules/filesystem/DirectoryReader.cpp

Issue 1227783004: Fix virtual/override/final usage in Source/modules/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 27 matching lines...) Expand all
38 38
39 namespace blink { 39 namespace blink {
40 40
41 class DirectoryReader::EntriesCallbackHelper final : public EntriesCallback { 41 class DirectoryReader::EntriesCallbackHelper final : public EntriesCallback {
42 public: 42 public:
43 explicit EntriesCallbackHelper(DirectoryReader* reader) 43 explicit EntriesCallbackHelper(DirectoryReader* reader)
44 : m_reader(reader) 44 : m_reader(reader)
45 { 45 {
46 } 46 }
47 47
48 virtual void handleEvent(const EntryHeapVector& entries) override 48 void handleEvent(const EntryHeapVector& entries) override
49 { 49 {
50 m_reader->addEntries(entries); 50 m_reader->addEntries(entries);
51 } 51 }
52 52
53 DEFINE_INLINE_VIRTUAL_TRACE() 53 DEFINE_INLINE_VIRTUAL_TRACE()
54 { 54 {
55 visitor->trace(m_reader); 55 visitor->trace(m_reader);
56 EntriesCallback::trace(visitor); 56 EntriesCallback::trace(visitor);
57 } 57 }
58 58
59 private: 59 private:
60 // FIXME: This Member keeps the reader alive until all of the readDirectory results are received. crbug.com/350285 60 // FIXME: This Member keeps the reader alive until all of the readDirectory results are received. crbug.com/350285
61 Member<DirectoryReader> m_reader; 61 Member<DirectoryReader> m_reader;
62 }; 62 };
63 63
64 class DirectoryReader::ErrorCallbackHelper final : public ErrorCallback { 64 class DirectoryReader::ErrorCallbackHelper final : public ErrorCallback {
65 public: 65 public:
66 explicit ErrorCallbackHelper(DirectoryReader* reader) 66 explicit ErrorCallbackHelper(DirectoryReader* reader)
67 : m_reader(reader) 67 : m_reader(reader)
68 { 68 {
69 } 69 }
70 70
71 virtual void handleEvent(FileError* error) override 71 void handleEvent(FileError* error) override
72 { 72 {
73 m_reader->onError(error); 73 m_reader->onError(error);
74 } 74 }
75 75
76 DEFINE_INLINE_VIRTUAL_TRACE() 76 DEFINE_INLINE_VIRTUAL_TRACE()
77 { 77 {
78 visitor->trace(m_reader); 78 visitor->trace(m_reader);
79 ErrorCallback::trace(visitor); 79 ErrorCallback::trace(visitor);
80 } 80 }
81 81
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 DEFINE_TRACE(DirectoryReader) 146 DEFINE_TRACE(DirectoryReader)
147 { 147 {
148 visitor->trace(m_entries); 148 visitor->trace(m_entries);
149 visitor->trace(m_error); 149 visitor->trace(m_error);
150 visitor->trace(m_entriesCallback); 150 visitor->trace(m_entriesCallback);
151 visitor->trace(m_errorCallback); 151 visitor->trace(m_errorCallback);
152 DirectoryReaderBase::trace(visitor); 152 DirectoryReaderBase::trace(visitor);
153 } 153 }
154 154
155 } 155 }
OLDNEW
« no previous file with comments | « Source/modules/filesystem/DirectoryReader.h ('k') | Source/modules/filesystem/DirectoryReaderSync.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698