Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Side by Side Diff: Source/modules/device_orientation/DeviceOrientationDispatcher.h

Issue 1227783004: Fix virtual/override/final usage in Source/modules/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 28 matching lines...) Expand all
39 namespace blink { 39 namespace blink {
40 40
41 class DeviceOrientationData; 41 class DeviceOrientationData;
42 class WebDeviceOrientationData; 42 class WebDeviceOrientationData;
43 43
44 // This class listens to device orientation data and notifies all registered con trollers. 44 // This class listens to device orientation data and notifies all registered con trollers.
45 class DeviceOrientationDispatcher final : public GarbageCollectedFinalized<Devic eOrientationDispatcher>, public PlatformEventDispatcher, public WebDeviceOrienta tionListener { 45 class DeviceOrientationDispatcher final : public GarbageCollectedFinalized<Devic eOrientationDispatcher>, public PlatformEventDispatcher, public WebDeviceOrienta tionListener {
46 USING_GARBAGE_COLLECTED_MIXIN(DeviceOrientationDispatcher); 46 USING_GARBAGE_COLLECTED_MIXIN(DeviceOrientationDispatcher);
47 public: 47 public:
48 static DeviceOrientationDispatcher& instance(); 48 static DeviceOrientationDispatcher& instance();
49 virtual ~DeviceOrientationDispatcher(); 49 ~DeviceOrientationDispatcher() override;
50 50
51 // Note that the returned object is owned by this class. 51 // Note that the returned object is owned by this class.
52 // FIXME: make the return value const, see crbug.com/233174. 52 // FIXME: make the return value const, see crbug.com/233174.
53 DeviceOrientationData* latestDeviceOrientationData(); 53 DeviceOrientationData* latestDeviceOrientationData();
54 54
55 // Inherited from WebDeviceOrientationListener. 55 // Inherited from WebDeviceOrientationListener.
56 virtual void didChangeDeviceOrientation(const WebDeviceOrientationData&) ove rride; 56 void didChangeDeviceOrientation(const WebDeviceOrientationData&) override;
57 57
58 DECLARE_VIRTUAL_TRACE(); 58 DECLARE_VIRTUAL_TRACE();
59 59
60 private: 60 private:
61 DeviceOrientationDispatcher(); 61 DeviceOrientationDispatcher();
62 62
63 // Inherited from PlatformEventDispatcher. 63 // Inherited from PlatformEventDispatcher.
64 virtual void startListening() override; 64 void startListening() override;
65 virtual void stopListening() override; 65 void stopListening() override;
66 66
67 Member<DeviceOrientationData> m_lastDeviceOrientationData; 67 Member<DeviceOrientationData> m_lastDeviceOrientationData;
68 }; 68 };
69 69
70 } // namespace blink 70 } // namespace blink
71 71
72 #endif // DeviceOrientationDispatcher_h 72 #endif // DeviceOrientationDispatcher_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698