Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: Source/modules/crypto/CryptoResultImpl.h

Issue 1227783004: Fix virtual/override/final usage in Source/modules/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 // * The CryptoResult interface must only be called from the origin thread. 52 // * The CryptoResult interface must only be called from the origin thread.
53 // * ref(), deref(), cancelled() and cancel() can be called from any thread. 53 // * ref(), deref(), cancelled() and cancel() can be called from any thread.
54 // * One of the completeWith***() functions must be called, or the 54 // * One of the completeWith***() functions must be called, or the
55 // m_resolver will be leaked until the ExecutionContext is destroyed. 55 // m_resolver will be leaked until the ExecutionContext is destroyed.
56 class CryptoResultImpl final : public CryptoResult { 56 class CryptoResultImpl final : public CryptoResult {
57 public: 57 public:
58 ~CryptoResultImpl(); 58 ~CryptoResultImpl();
59 59
60 static PassRefPtrWillBeRawPtr<CryptoResultImpl> create(ScriptState*); 60 static PassRefPtrWillBeRawPtr<CryptoResultImpl> create(ScriptState*);
61 61
62 virtual void completeWithError(WebCryptoErrorType, const WebString&) overrid e; 62 void completeWithError(WebCryptoErrorType, const WebString&) override;
63 virtual void completeWithBuffer(const void* bytes, unsigned bytesSize) overr ide; 63 void completeWithBuffer(const void* bytes, unsigned bytesSize) override;
64 virtual void completeWithJson(const char* utf8Data, unsigned length) overrid e; 64 void completeWithJson(const char* utf8Data, unsigned length) override;
65 virtual void completeWithBoolean(bool) override; 65 void completeWithBoolean(bool) override;
66 virtual void completeWithKey(const WebCryptoKey&) override; 66 void completeWithKey(const WebCryptoKey&) override;
67 virtual void completeWithKeyPair(const WebCryptoKey& publicKey, const WebCry ptoKey& privateKey) override; 67 void completeWithKeyPair(const WebCryptoKey& publicKey, const WebCryptoKey& privateKey) override;
68 virtual bool cancelled() const override; 68 bool cancelled() const override;
69 69
70 // If called after completion (including cancellation) will return an empty 70 // If called after completion (including cancellation) will return an empty
71 // ScriptPromise. 71 // ScriptPromise.
72 ScriptPromise promise(); 72 ScriptPromise promise();
73 73
74 private: 74 private:
75 class Resolver; 75 class Resolver;
76 explicit CryptoResultImpl(ScriptState*); 76 explicit CryptoResultImpl(ScriptState*);
77 77
78 void clearResolver(); 78 void clearResolver();
79 void cancel(); 79 void cancel();
80 80
81 // FIXME: ScriptPromiseResolver should not be exported. 81 // FIXME: ScriptPromiseResolver should not be exported.
82 // Instead, use ScriptPromise. 82 // Instead, use ScriptPromise.
83 ScriptPromiseResolver* m_resolver; 83 ScriptPromiseResolver* m_resolver;
84 volatile int m_cancelled; 84 volatile int m_cancelled;
85 }; 85 };
86 86
87 } // namespace blink 87 } // namespace blink
88 88
89 #endif 89 #endif
OLDNEW
« no previous file with comments | « Source/modules/credentialmanager/CredentialsContainer.cpp ('k') | Source/modules/crypto/CryptoResultImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698