Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1227763002: Avoid clearing pointers on layers still in the mapping's vector of layers. (Closed)

Created:
5 years, 5 months ago by Stephen Chennney
Modified:
5 years, 5 months ago
Reviewers:
Ian Vollick
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Avoid clearing pointers on layers still in the mapping's vector of layers. When adjusting layers, a particular layer may be added to a grouped mapping at a location earlier than where it already appears in the layer vector. When we then clear the unused entries in the list, we remove the layer and null its group mapping, despite it still being present earlier in the vector. R=vollick BUG=507988 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198534

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp View 1 chunk +13 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Stephen Chennney
The clusterfuzz example on this is extremely nasty, so no new test.
5 years, 5 months ago (2015-07-08 18:46:59 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227763002/1
5 years, 5 months ago (2015-07-08 18:48:12 UTC) #3
Ian Vollick
On 2015/07/08 18:48:12, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
5 years, 5 months ago (2015-07-08 19:23:23 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-08 19:48:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227763002/1
5 years, 5 months ago (2015-07-08 20:34:40 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 20:38:29 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198534

Powered by Google App Engine
This is Rietveld 408576698