Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1227723002: Add gradle wrappers for Android app builds (Closed)

Created:
5 years, 5 months ago by djsollen
Modified:
5 years, 5 months ago
Reviewers:
joshualitt, scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add gradle wrappers for Android app builds These wrappers are approxiately 56K in size and are the recommened way to use Gradle. It also ensures that developers wanting to build the app don't need install an additional dependency. Committed: https://skia.googlesource.com/skia/+/8de81806db43c1a1a7bafdb95c77ac4fa4a67f49

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -0 lines) Patch
A platform_tools/android/apps/gradle/wrapper/gradle-wrapper.jar View Binary file 0 comments Download
A platform_tools/android/apps/gradle/wrapper/gradle-wrapper.properties View 1 chunk +6 lines, -0 lines 0 comments Download
A platform_tools/android/apps/gradlew View 1 chunk +164 lines, -0 lines 1 comment Download

Messages

Total messages: 10 (3 generated)
djsollen
5 years, 5 months ago (2015-07-08 13:56:40 UTC) #2
djsollen
5 years, 5 months ago (2015-07-08 13:57:41 UTC) #4
scroggo
I'm not a good person to review the bash script, and I know very little ...
5 years, 5 months ago (2015-07-08 15:48:41 UTC) #5
djsollen
looking for a rubber stamp as this code is provided directly by gradle and I ...
5 years, 5 months ago (2015-07-08 16:40:20 UTC) #6
scroggo
lgtm
5 years, 5 months ago (2015-07-08 17:41:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227723002/1
5 years, 5 months ago (2015-07-08 17:41:30 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 17:50:45 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8de81806db43c1a1a7bafdb95c77ac4fa4a67f49

Powered by Google App Engine
This is Rietveld 408576698