chrome/browser/notifications/notification.cc - Issue 12277024: Notificaitons refactor step 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification.cc

Issue 12277024: Notificaitons refactor step 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more feedback from Steven Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/notifications/notification.cc

diff --git a/chrome/browser/notifications/notification.cc b/chrome/browser/notifications/notification.cc

index 376ec0f08dc1e665de26eb6885414caefe6f409a..ffb287157aa98cc34ff9051601cecbf06b65882e 100644

--- a/chrome/browser/notifications/notification.cc

+++ b/chrome/browser/notifications/notification.cc

@@ -11,7 +11,7 @@ Notification::Notification(const GURL& origin_url,

const string16& display_source,

const string16& replace_id,

NotificationDelegate* delegate)

- : type_(ui::notifications::NOTIFICATION_TYPE_SIMPLE),

+ : type_(message_center::NOTIFICATION_TYPE_SIMPLE),

origin_url_(origin_url),

is_html_(true),

content_url_(content_url),

@@ -28,7 +28,7 @@ Notification::Notification(const GURL& origin_url,

const string16& display_source,

const string16& replace_id,

NotificationDelegate* delegate)

- : type_(ui::notifications::NOTIFICATION_TYPE_SIMPLE),

+ : type_(message_center::NOTIFICATION_TYPE_SIMPLE),

origin_url_(origin_url),

icon_url_(icon_url),

is_html_(false),

@@ -42,7 +42,7 @@ Notification::Notification(const GURL& origin_url,

icon_url, title, body, dir));

}

-Notification::Notification(ui::notifications::NotificationType type,

+Notification::Notification(message_center::NotificationType type,

const GURL& origin_url,

const GURL& icon_url,

const string16& title,

@@ -78,7 +78,7 @@ Notification::Notification(const GURL& origin_url,

const string16& display_source,

const string16& replace_id,

NotificationDelegate* delegate)

- : type_(ui::notifications::NOTIFICATION_TYPE_SIMPLE),

+ : type_(message_center::NOTIFICATION_TYPE_SIMPLE),

origin_url_(origin_url),

icon_(icon),

is_html_(false),

« no previous file with comments | « chrome/browser/notifications/notification.h ('k') | chrome/browser/ui/views/ash/balloon_view_ash.cc » ('j') | no next file with comments »