chrome/browser/notifications/message_center_notification_manager.cc - Issue 12277024: Notificaitons refactor step 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/message_center_notification_manager.cc

Issue 12277024: Notificaitons refactor step 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more feedback from Steven Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/notifications/message_center_notification_manager.cc

diff --git a/chrome/browser/notifications/message_center_notification_manager.cc b/chrome/browser/notifications/message_center_notification_manager.cc

index 1aa4665d0c3dc5a818e743624ff7929d1d0c0116..a0a31f04b5b2d7a9c9abe048fe853e9e98b9044d 100644

--- a/chrome/browser/notifications/message_center_notification_manager.cc

+++ b/chrome/browser/notifications/message_center_notification_manager.cc

@@ -248,7 +248,7 @@ void MessageCenterNotificationManager::ImageDownloads::StartDownloads(

// Notification image.

StartDownloadByKey(

notification,

- ui::notifications::kImageUrlKey,

+ message_center::kImageUrlKey,

message_center::kNotificationPreferredImageSize,

base::Bind(&message_center::MessageCenter::SetNotificationImage,

base::Unretained(message_center_),

@@ -257,13 +257,13 @@ void MessageCenterNotificationManager::ImageDownloads::StartDownloads(

// Notification button icons.

StartDownloadByKey(

notification,

- ui::notifications::kButtonOneIconUrlKey,

+ message_center::kButtonOneIconUrlKey,

message_center::kNotificationButtonIconSize,

base::Bind(&message_center::MessageCenter::SetNotificationButtonIcon,

base::Unretained(message_center_),

notification.notification_id(), 0));

StartDownloadByKey(

- notification, ui::notifications::kButtonTwoIconUrlKey,

+ notification, message_center::kButtonTwoIconUrlKey,

message_center::kNotificationButtonIconSize,

base::Bind(&message_center::MessageCenter::SetNotificationButtonIcon,

base::Unretained(message_center_),

« no previous file with comments | « chrome/browser/extensions/api/notification/notification_api.cc ('k') | chrome/browser/notifications/notification.h » ('j') | no next file with comments »