Notificaitons refactor step 2

ui/message_center/message_center_bubble.cc

Index: ui/message_center/message_center_bubble.cc
diff --git a/ui/message_center/message_center_bubble.cc b/ui/message_center/message_center_bubble.cc
index 8cf507ad610a2c78e77364a8c2d7264f1363f0ca..141b5be8731f23ad5e3eeab29c8004e3ebdfac86 100644
--- a/ui/message_center/message_center_bubble.cc
+++ b/ui/message_center/message_center_bubble.cc
@@ -408,9 +408,8 @@ class MessageCenterContentsView : public views::View {
     for (NotificationList::Notifications::const_iterator iter =
              notifications.begin(); iter != notifications.end(); ++iter) {
       MessageView* view =
-          NotificationView::ViewForNotification(*iter, list_delegate_);
+          NotificationView::ViewForNotification(*(*iter), list_delegate_);

[stevenjb, 2013/02/25 23:55:56]

I know this is unrelated to this CL, but could view ever be NULL here?

[Dmitry Titov, 2013/02/26 01:01:51]

I think you are asking if the ViewForNotification() can ever return NULL so the
subsequent code crashes. It can't because ViewForNotificaiton is essentially a
Create(), it calls new() inside. Will rename in subsequent CL.

       view->set_scroller(scroller_);
-      view->SetUpView();
       if (IsRichNotificationEnabled())
         view->set_border(new MessageViewShadowBorder());
       scroll_content_->AddChildView(view);
@@ -508,8 +507,8 @@ void MessageCenterBubble::OnBubbleViewDestroyed() {
 void MessageCenterBubble::UpdateBubbleView() {
   if (!bubble_view())
     return;  // Could get called after view is closed
-  NotificationList::Notifications notifications;
-  list_delegate()->GetNotificationList()->GetNotifications(&notifications);
+  const NotificationList::Notifications& notifications =
+      list_delegate()->GetNotificationList()->GetNotifications();
   contents_view_->Update(notifications);
   bubble_view()->Show();
   bubble_view()->UpdateBubble();