net/disk_cache/simple/simple_entry_impl.h - Issue 12277004: Make SimpleEntryImpl::Close asynchronous.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/disk_cache/simple/simple_entry_impl.h

Issue 12277004: Make SimpleEntryImpl::Close asynchronous. (Closed) Base URL: http://git.chromium.org/git/chromium.git@3-doomdoom

Patch Set: remediation Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/disk_cache/simple/simple_entry_impl.h

diff --git a/net/disk_cache/simple/simple_entry_impl.h b/net/disk_cache/simple/simple_entry_impl.h

index 4dc76ddddd803c45106a0081f1d2c2e79535daaa..d7877bbc5b63a1944e7974d23c480f775ae120c1 100644

--- a/net/disk_cache/simple/simple_entry_impl.h

+++ b/net/disk_cache/simple/simple_entry_impl.h

@@ -89,9 +89,11 @@ class SimpleEntryImpl : public Entry {

// Called after a SimpleSynchronousEntry has completed an asynchronous IO

// operation, such as ReadData() or WriteData(). Calls |completion_callback|.

+ // If |entry| no longer exists, then it ensures |sync_entry| is closed.

static void EntryOperationComplete(

const CompletionCallback& completion_callback,

base::WeakPtr<SimpleEntryImpl> entry,

+ SimpleSynchronousEntry* sync_entry,

int result);

// Called on construction and also after the completion of asynchronous IO to