Make sure ShellIntegration::CommandLineArgsForLauncher respects the UserDataDir policy.

chrome/app/chrome_main_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/app/chrome_main_delegate.h"
 
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
 #include "base/message_loop.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/stats_counters.h"
 #include "base/path_service.h"
 #include "base/process_util.h"
 #include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "chrome/browser/chrome_content_browser_client.h"
 #include "chrome/browser/defaults.h"
 #include "chrome/browser/diagnostics/diagnostics_main.h"
+#include "chrome/browser/policy/policy_path_parser.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_content_client.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_paths_internal.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/chrome_version_info.h"
 #include "chrome/common/logging_chrome.h"
 #include "chrome/common/profiling.h"
 #include "chrome/common/startup_metric_utils.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/plugin/chrome_content_plugin_client.h"
 #include "chrome/renderer/chrome_content_renderer_client.h"
 #include "chrome/utility/chrome_content_utility_client.h"
 #include "content/public/common/content_client.h"
 #include "content/public/common/content_paths.h"
 #include "content/public/common/content_switches.h"
 #include "ui/base/ui_base_switches.h"
 
 #if defined(OS_WIN)
 #include <algorithm>
 #include <atlbase.h>
 #include <malloc.h>
 #include "base/string_util.h"
-#include "base/win/registry.h"
-#include "chrome/browser/policy/policy_path_parser.h"
-#include "policy/policy_constants.h"
 #include "sandbox/win/src/sandbox.h"
 #include "tools/memory_watcher/memory_watcher.h"
 #include "ui/base/resource/resource_bundle_win.h"
 #endif
 
 #if defined(OS_MACOSX)
 #include "base/mac/mac_util.h"
 #include "base/mac/os_crash_dumps.h"
 #include "chrome/app/breakpad_mac.h"
 #include "chrome/app/chrome_main_mac.h"
@@ skipping 62 matching lines @@
 // some apps fail to properly escape arguments.
 bool HasDeprecatedArguments(const std::wstring& command_line) {
   const wchar_t kChromeHtml[] = L"chromehtml:";
   std::wstring command_line_lower = command_line;
   // We are only searching for ASCII characters so this is OK.
   StringToLowerASCII(&command_line_lower);
   std::wstring::size_type pos = command_line_lower.find(kChromeHtml);
   return (pos != std::wstring::npos);
 }
 
-// Checks if the registry key exists in the given hive and expands any
-// variables in the string.
-bool LoadUserDataDirPolicyFromRegistry(HKEY hive,
-                                       const std::wstring& key_name,
-                                       base::FilePath* user_data_dir) {
-  std::wstring value;
-
-  base::win::RegKey policy_key(hive,
-                               policy::kRegistryMandatorySubKey,
-                               KEY_READ);
-  if (policy_key.ReadValue(key_name.c_str(), &value) == ERROR_SUCCESS) {
-    *user_data_dir =
-        base::FilePath(policy::path_parser::ExpandPathVariables(value));
-    return true;
-  }
-  return false;
-}
-
-void CheckUserDataDirPolicy(base::FilePath* user_data_dir) {
-  DCHECK(user_data_dir);
-  // We are running as Chrome Frame if we were invoked with user-data-dir,
-  // chrome-frame, and automation-channel switches.
-  CommandLine* command_line = CommandLine::ForCurrentProcess();
-  const bool is_chrome_frame =
-      !user_data_dir->empty() &&
-      command_line->HasSwitch(switches::kChromeFrame) &&
-      command_line->HasSwitch(switches::kAutomationClientChannelID);
-
-  // In the case of Chrome Frame, the last path component of the user-data-dir
-  // provided on the command line must be preserved since it is specific to
-  // CF's host.
-  base::FilePath cf_host_dir;
-  if (is_chrome_frame)
-    cf_host_dir = user_data_dir->BaseName();
-
-  // Policy from the HKLM hive has precedence over HKCU so if we have one here
-  // we don't have to try to load HKCU.
-  const char* key_name_ascii = (is_chrome_frame ? policy::key::kGCFUserDataDir :
-                                policy::key::kUserDataDir);
-  std::wstring key_name(ASCIIToWide(key_name_ascii));
-  if (LoadUserDataDirPolicyFromRegistry(HKEY_LOCAL_MACHINE, key_name,
-                                        user_data_dir) ||
-      LoadUserDataDirPolicyFromRegistry(HKEY_CURRENT_USER, key_name,
-                                        user_data_dir)) {
-    // A Group Policy value was loaded.  Append the Chrome Frame host directory
-    // if relevant.
-    if (is_chrome_frame)
-      *user_data_dir = user_data_dir->Append(cf_host_dir);
-  }
-}
-
 // If we try to access a path that is not currently available, we want the call
 // to fail rather than show an error dialog.
 void SuppressWindowsErrorDialogs() {
   UINT new_flags = SEM_FAILCRITICALERRORS |
                    SEM_NOOPENFILEERRORBOX;
 
   // Preserve existing error mode.
   UINT existing_flags = SetErrorMode(new_flags);
   SetErrorMode(existing_flags | new_flags);
 }
@@ skipping 349 matching lines @@
                         chrome::GetVersionedDirectory().
                         Append(chrome::kHelperProcessExecutablePath));
 
   InitMacCrashReporter(command_line, process_type);
 #endif
 
   // Notice a user data directory override if any
   base::FilePath user_data_dir =
       command_line.GetSwitchValuePath(switches::kUserDataDir);
 #if defined(OS_MACOSX) || defined(OS_WIN)
-  CheckUserDataDirPolicy(&user_data_dir);
+  policy::path_parser::CheckUserDataDirPolicy(&user_data_dir);
 #endif
   if (!user_data_dir.empty()) {
     CHECK(PathService::OverrideAndCreateIfNeeded(
         chrome::DIR_USER_DATA,
         user_data_dir,
         chrome::ProcessNeedsProfileDir(process_type)));
   }
 
   stats_counter_timer_.reset(new base::StatsCounterTimer("Chrome.Init"));
   startup_timer_.reset(new base::StatsScope<base::StatsCounterTimer>
@@ skipping 207 matching lines @@
 
 content::ContentRendererClient*
     ChromeMainDelegate::CreateContentRendererClient() {
   return &g_chrome_content_renderer_client.Get();
 }
 
 content::ContentUtilityClient*
     ChromeMainDelegate::CreateContentUtilityClient() {
   return &g_chrome_content_utility_client.Get();
 }