Make sure ShellIntegration::CommandLineArgsForLauncher respects the UserDataDir policy.

Make sure ShellIntegration::CommandLineArgsForLauncher respects the UserDataDir policy.

If this is not done shortcuts created will not contain the right path and will
cause faulty behavior on Windows.

BUG=173237
TEST=As described in the bug.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183546

[pastarmovj, 2013-02-18 12:41:30]

Hi guys,
please review this CL that makes shell integration aware of the UserDataDir
policy. Had to move some code from chrome_main* to a more central location to
enable that.

@Brett: Please do a full review.

@Carlos: Please do owner review of chrome/app/* (it's almost  remove only
change)

Thanks!

[cpu_(ooo_6.6-7.5), 2013-02-19 04:48:15]

/app/ lgtm

[brettw, 2013-02-19 04:49:52]

https://codereview.chromium.org/12277002/diff/13001/chrome/browser/policy/pol...
File chrome/browser/policy/policy_path_parser.h (right):

https://codereview.chromium.org/12277002/diff/13001/chrome/browser/policy/pol...
chrome/browser/policy/policy_path_parser.h:55: void
CheckUserDataDirPolicy(base::FilePath* user_data_dir);
The comment here doesn't explain what the argument is. Is it in our out? It
looks like it isn't always filled out, can you also specify under what
conditions this happens?

https://codereview.chromium.org/12277002/diff/13001/chrome/browser/policy/pol...
File chrome/browser/policy/policy_path_parser_mac.mm (right):

https://codereview.chromium.org/12277002/diff/13001/chrome/browser/policy/pol...
chrome/browser/policy/policy_path_parser_mac.mm:110: *user_data_dir =
FilePath(string_value);
Use base::FilePath

[pastarmovj, 2013-02-19 14:09:43]

Thanks for the reviews! 

@Brett: Addressed your comments. PTAL.

https://codereview.chromium.org/12277002/diff/13001/chrome/browser/policy/pol...
File chrome/browser/policy/policy_path_parser.h (right):

https://codereview.chromium.org/12277002/diff/13001/chrome/browser/policy/pol...
chrome/browser/policy/policy_path_parser.h:55: void
CheckUserDataDirPolicy(base::FilePath* user_data_dir);
On 2013/02/19 04:49:52, brettw wrote:
> The comment here doesn't explain what the argument is. Is it in our out? It
> looks like it isn't always filled out, can you also specify under what
> conditions this happens?

Done.

https://codereview.chromium.org/12277002/diff/13001/chrome/browser/policy/pol...
File chrome/browser/policy/policy_path_parser_mac.mm (right):

https://codereview.chromium.org/12277002/diff/13001/chrome/browser/policy/pol...
chrome/browser/policy/policy_path_parser_mac.mm:110: *user_data_dir =
FilePath(string_value);
On 2013/02/19 04:49:52, brettw wrote:
> Use base::FilePath

Done.

[brettw, 2013-02-19 18:23:45]

lgtm

https://codereview.chromium.org/12277002/diff/11003/chrome/browser/policy/pol...
File chrome/browser/policy/policy_path_parser.h (right):

https://codereview.chromium.org/12277002/diff/11003/chrome/browser/policy/pol...
chrome/browser/policy/policy_path_parser.h:55: // The function will fill
|user_data_dir| if the corresponding policy is set and
Can you rephrase this a bit? I don't know what the "corresponding policy" is. I
gather there is a policy for where user data dirs should be, can you say that
explicitly? (This isn't clear to random people not working on policy stuff).

[pastarmovj, 2013-02-20 10:15:05]

https://codereview.chromium.org/12277002/diff/11003/chrome/browser/policy/pol...
File chrome/browser/policy/policy_path_parser.h (right):

https://codereview.chromium.org/12277002/diff/11003/chrome/browser/policy/pol...
chrome/browser/policy/policy_path_parser.h:55: // The function will fill
|user_data_dir| if the corresponding policy is set and
On 2013/02/19 18:23:45, brettw wrote:
> Can you rephrase this a bit? I don't know what the "corresponding policy" is.
I
> gather there is a policy for where user data dirs should be, can you say that
> explicitly? (This isn't clear to random people not working on policy stuff).

Done.

[commit-bot: I haz the power, 2013-02-20 10:16:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/12277002/19001

[commit-bot: I haz the power, 2013-02-20 10:17:03]

Presubmit check for 12277002-19001 failed and returned exit status 1.

INFO:root:Found 7 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/policy/PRESUBMIT.py

** Presubmit Messages **
Your #include order seems to be broken. Send mail to
marja@chromium.org if this is not the case.
      chrome/browser/policy/policy_path_parser_win.cc:11

** Presubmit Warnings **
New code should not use wstrings.  If you are calling a cross-platform API that
accepts a wstring, fix the API.
    chrome/browser/policy/policy_path_parser_win.cc:23
    chrome/browser/policy/policy_path_parser_win.cc:25
    chrome/browser/policy/policy_path_parser_win.cc:157

Presubmit checks took 1.1s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!