Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart

Issue 1227643002: dart2js: Remove unneeded getters in full emitter. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js.js_emitter; 5 part of dart2js.js_emitter;
6 6
7 7
8 class OldEmitter implements Emitter { 8 class OldEmitter implements Emitter {
9 final Compiler compiler; 9 final Compiler compiler;
10 final CodeEmitterTask task; 10 final CodeEmitterTask task;
(...skipping 20 matching lines...) Expand all
31 31
32 final Namer namer; 32 final Namer namer;
33 ConstantEmitter constantEmitter; 33 ConstantEmitter constantEmitter;
34 NativeEmitter get nativeEmitter => task.nativeEmitter; 34 NativeEmitter get nativeEmitter => task.nativeEmitter;
35 TypeTestRegistry get typeTestRegistry => task.typeTestRegistry; 35 TypeTestRegistry get typeTestRegistry => task.typeTestRegistry;
36 36
37 // The full code that is written to each hunk part-file. 37 // The full code that is written to each hunk part-file.
38 Map<OutputUnit, CodeOutput> outputBuffers = new Map<OutputUnit, CodeOutput>(); 38 Map<OutputUnit, CodeOutput> outputBuffers = new Map<OutputUnit, CodeOutput>();
39 39
40 String classesCollector; 40 String classesCollector;
41 Set<ClassElement> get neededClasses => task.neededClasses;
42 Map<OutputUnit, List<ClassElement>> get outputClassLists
43 => task.outputClassLists;
44 Map<OutputUnit, List<ConstantValue>> get outputConstantLists
45 => task.outputConstantLists;
46 final Map<jsAst.Name, String> mangledFieldNames = 41 final Map<jsAst.Name, String> mangledFieldNames =
47 new HashMap<jsAst.Name, String>(); 42 new HashMap<jsAst.Name, String>();
48 final Map<jsAst.Name, String> mangledGlobalFieldNames = 43 final Map<jsAst.Name, String> mangledGlobalFieldNames =
49 new HashMap<jsAst.Name, String>(); 44 new HashMap<jsAst.Name, String>();
50 final Set<jsAst.Name> recordedMangledNames = new Set<jsAst.Name>(); 45 final Set<jsAst.Name> recordedMangledNames = new Set<jsAst.Name>();
51 46
52 List<TypedefElement> get typedefsNeededForReflection => 47 List<TypedefElement> get typedefsNeededForReflection =>
53 task.typedefsNeededForReflection; 48 task.typedefsNeededForReflection;
54 49
55 JavaScriptBackend get backend => compiler.backend; 50 JavaScriptBackend get backend => compiler.backend;
(...skipping 1952 matching lines...) Expand 10 before | Expand all | Expand 10 after
2008 for (Element element in compiler.enqueuer.codegen.newlyEnqueuedElements) { 2003 for (Element element in compiler.enqueuer.codegen.newlyEnqueuedElements) {
2009 if (element.isInstanceMember) { 2004 if (element.isInstanceMember) {
2010 cachedClassBuilders.remove(element.enclosingClass); 2005 cachedClassBuilders.remove(element.enclosingClass);
2011 2006
2012 nativeEmitter.cachedBuilders.remove(element.enclosingClass); 2007 nativeEmitter.cachedBuilders.remove(element.enclosingClass);
2013 2008
2014 } 2009 }
2015 } 2010 }
2016 } 2011 }
2017 } 2012 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698