Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1227603002: X87: Debugger: use debug break slots instead of ICs (except for calls). (Closed)

Created:
5 years, 5 months ago by chunyang.dai
Modified:
5 years, 5 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Debugger: use debug break slots instead of ICs (except for calls). port a8a4c364c2ad4c1e5f4c6e1f1580d75ff1a35a4f (r29487). original commit message: BUG= Committed: https://crrev.com/c935d2b9ee142fcc89e900533b9b5610c43520ec Cr-Commit-Position: refs/heads/master@{#29508}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -116 lines) Patch
M src/x87/debug-x87.cc View 2 chunks +0 lines, -46 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 31 chunks +49 lines, -70 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 5 months ago (2015-07-07 02:11:05 UTC) #2
Weiliang
lgtm
5 years, 5 months ago (2015-07-07 07:40:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227603002/1
5 years, 5 months ago (2015-07-07 07:40:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-07 08:04:14 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 08:04:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c935d2b9ee142fcc89e900533b9b5610c43520ec
Cr-Commit-Position: refs/heads/master@{#29508}

Powered by Google App Engine
This is Rietveld 408576698