Add reset all button to flags page

Add reset all button to flags page

Adds a "Reset all to default" button at the top of the flags page to simplify
getting all experiments back to their default state.

BUG=139307
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183357

[James Hawkins, 2013-02-19 20:49:54]

https://codereview.chromium.org/12276012/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/12276012/diff/1/chrome/browser/about_flags.cc...
chrome/browser/about_flags.cc:1518: void ResetAllExperiments(PrefService* prefs)
{
Why is this called ResetAllExperiments but the internal call is RemoveAllFlags?

https://codereview.chromium.org/12276012/diff/1/chrome/browser/resources/flag...
File chrome/browser/resources/flags.html (right):

https://codereview.chromium.org/12276012/diff/1/chrome/browser/resources/flag...
chrome/browser/resources/flags.html:37: type="button"
Note that this file at some point needs to be cleaned up to match the style
guide :-(

https://codereview.chromium.org/12276012/diff/1/chrome/browser/resources/flag...
chrome/browser/resources/flags.html:39: >RESET ALL TO DEFAULT</button>
nit: Don't include placeholder placeholder text, e.g., "RESET ALL TO DEFAULT"

[jryans, 2013-02-19 21:28:28]

https://codereview.chromium.org/12276012/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/12276012/diff/1/chrome/browser/about_flags.cc...
chrome/browser/about_flags.cc:1518: void ResetAllExperiments(PrefService* prefs)
{
On 2013/02/19 20:49:54, James Hawkins wrote:
> Why is this called ResetAllExperiments but the internal call is
RemoveAllFlags?

Generally there seems be a mixture of "experiment" vs. "flag" throughout the
various interfaces. I was aiming for "flag" inside RemoveAllFlags since it's a
member of "FlagsState", but used "experiment" the rest of the way, since that
seemed to align with the words used at other levels. I am happy to make them all
either one, if one seems better than the other.

https://codereview.chromium.org/12276012/diff/1/chrome/browser/resources/flag...
File chrome/browser/resources/flags.html (right):

https://codereview.chromium.org/12276012/diff/1/chrome/browser/resources/flag...
chrome/browser/resources/flags.html:37: type="button"
On 2013/02/19 20:49:54, James Hawkins wrote:
> Note that this file at some point needs to be cleaned up to match the style
> guide :-(

Yeah, I attempted to emulate what I saw elsewhere in the file, but I agree it
doesn't seem to follow the guide.

https://codereview.chromium.org/12276012/diff/1/chrome/browser/resources/flag...
chrome/browser/resources/flags.html:39: >RESET ALL TO DEFAULT</button>
On 2013/02/19 20:49:54, James Hawkins wrote:
> nit: Don't include placeholder placeholder text, e.g., "RESET ALL TO DEFAULT"

Okay, removed.

[James Hawkins, 2013-02-19 21:38:43]

lgtm

https://codereview.chromium.org/12276012/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/12276012/diff/1/chrome/browser/about_flags.cc...
chrome/browser/about_flags.cc:1518: void ResetAllExperiments(PrefService* prefs)
{
On 2013/02/19 21:28:28, jryans wrote:
> On 2013/02/19 20:49:54, James Hawkins wrote:
> > Why is this called ResetAllExperiments but the internal call is
> RemoveAllFlags?
> 
> Generally there seems be a mixture of "experiment" vs. "flag" throughout the
> various interfaces. I was aiming for "flag" inside RemoveAllFlags since it's a
> member of "FlagsState", but used "experiment" the rest of the way, since that
> seemed to align with the words used at other levels. I am happy to make them
all
> either one, if one seems better than the other.

I'd go with Flags for both.

[commit-bot: I haz the power, 2013-02-19 22:15:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jryans@chromium.org/12276012/6002

[commit-bot: I haz the power, 2013-02-20 00:13:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jryans@chromium.org/12276012/6002

[commit-bot: I haz the power, 2013-02-20 01:20:02]

Change committed as 183357