chrome/browser/ui/webui/constrained_web_dialog_ui.h - Issue 12276010: Factor out uses of the WebContentsModalDialog interface from platform-independent code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/constrained_web_dialog_ui.h

Issue 12276010: Factor out uses of the WebContentsModalDialog interface from platform-independent code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: remove CloseWebContentsModalDialog call from ConstrainedWebDialogDelegateBase Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/login_prompt_cocoa.mm ('K') | « chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc ('k') | chrome/browser/ui/webui/constrained_web_dialog_ui_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/constrained_web_dialog_ui.h

diff --git a/chrome/browser/ui/webui/constrained_web_dialog_ui.h b/chrome/browser/ui/webui/constrained_web_dialog_ui.h

index 791e0bf4fc8e74a12940f16a2372513bd4534a44..6f167f0ebd712883021cbba6cc2c0961c4296b01 100644

--- a/chrome/browser/ui/webui/constrained_web_dialog_ui.h

+++ b/chrome/browser/ui/webui/constrained_web_dialog_ui.h

@@ -7,8 +7,7 @@

#include "base/compiler_specific.h"

#include "content/public/browser/web_ui_controller.h"

-class WebContentsModalDialog;

+#include "ui/gfx/native_widget_types.h"

namespace content {

class BrowserContext;

@@ -35,12 +34,12 @@ class ConstrainedWebDialogDelegate {

// released WebContents.

virtual void ReleaseWebContentsOnDialogClose() = 0;

- // Returns the WebContentsModalDialog.

- virtual WebContentsModalDialog* GetWindow() = 0;

// Returns the WebContents owned by the constrained window.

virtual content::WebContents* GetWebContents() = 0;

+ // Returns the NativeWindow used to display the dialog.

+ virtual gfx::NativeWindow GetNativeWindow() = 0;

protected:

virtual ~ConstrainedWebDialogDelegate() {}

};