Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3524)

Unified Diff: chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm

Issue 12276010: Factor out uses of the WebContentsModalDialog interface from platform-independent code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove CloseWebContentsModalDialog call from ConstrainedWebDialogDelegateBase Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm
diff --git a/chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm b/chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm
index dd710c11266064362b6467290971d5fef6ba0d90..055ca8b3a9dd67358e3ab7a1906c20e3df0305fc 100644
--- a/chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm
+++ b/chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm
@@ -46,8 +46,8 @@ class ConstrainedWebDialogDelegateMac :
virtual void ReleaseWebContentsOnDialogClose() OVERRIDE {
return impl_->ReleaseWebContentsOnDialogClose();
}
- virtual WebContentsModalDialog* GetWindow() OVERRIDE {
- return impl_->GetWindow();
+ virtual gfx::NativeWindow GetNativeWindow() OVERRIDE {
+ return impl_->GetNativeWindow();
}
virtual WebContents* GetWebContents() OVERRIDE {
return impl_->GetWebContents();
@@ -92,7 +92,6 @@ ConstrainedWebDialogDelegateMac::ConstrainedWebDialogDelegateMac(
initWithCustomWindow:window_]);
constrained_window_.reset(new ConstrainedWindowMac(
this, web_contents, sheet));
- return impl_->set_window(constrained_window_.get());
}
ConstrainedWebDialogDelegate* CreateConstrainedWebDialog(
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/login_prompt_cocoa.mm » ('j') | chrome/browser/ui/cocoa/login_prompt_cocoa.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698