Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: chrome/browser/ui/android/login_prompt_android.cc

Issue 12276010: Factor out uses of the WebContentsModalDialog interface from platform-independent code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove incorrect override Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/login/login_prompt.h" 5 #include "chrome/browser/ui/login/login_prompt.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "base/string16.h" 9 #include "base/string16.h"
10 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 } else { 63 } else {
64 CancelAuth(); 64 CancelAuth();
65 LOG(WARNING) << "HTTP Authentication failed because TabAndroid is " 65 LOG(WARNING) << "HTTP Authentication failed because TabAndroid is "
66 "missing"; 66 "missing";
67 } 67 }
68 } 68 }
69 69
70 protected: 70 protected:
71 virtual ~LoginHandlerAndroid() {} 71 virtual ~LoginHandlerAndroid() {}
72 72
73 virtual void CloseDialog() OVERRIDE {}
74
73 private: 75 private:
74 scoped_ptr<ChromeHttpAuthHandler> chrome_http_auth_handler_; 76 scoped_ptr<ChromeHttpAuthHandler> chrome_http_auth_handler_;
75 }; 77 };
76 78
77 // static 79 // static
78 LoginHandler* LoginHandler::Create(net::AuthChallengeInfo* auth_info, 80 LoginHandler* LoginHandler::Create(net::AuthChallengeInfo* auth_info,
79 net::URLRequest* request) { 81 net::URLRequest* request) {
80 return new LoginHandlerAndroid(auth_info, request); 82 return new LoginHandlerAndroid(auth_info, request);
81 } 83 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698