Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: tests/gcl_unittest.py

Issue 12276007: Add patchset number on manual commit comment. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« git_cl.py ('K') | « git_cl.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/gcl_unittest.py
diff --git a/tests/gcl_unittest.py b/tests/gcl_unittest.py
index 91c7aeb938e4973bc4be7cfc5ecd889205dfa2ae..feac59fba5bd2efebf1768adde91f68a826c6e5a 100755
--- a/tests/gcl_unittest.py
+++ b/tests/gcl_unittest.py
@@ -51,6 +51,7 @@ class GclTestsBase(SuperMoxTestBase):
change_info.GetIssueDescription = lambda : change_info.description
change_info.GetFileNames = lambda : [f[1] for f in change_info.files]
change_info.GetLocalRoot = lambda : 'proout'
+ change_info.GetIssueProperties = lambda : { 'patchsets': [1337] }
change_info.patch = None
change_info.rietveld = 'https://my_server'
change_info.reviewers = None
@@ -187,7 +188,8 @@ class ChangeInfoUnittest(GclTestsBase):
self.mox.ReplayAll()
members = [
'AddComment', 'CloseIssue', 'Delete', 'Exists', 'GetFiles',
- 'GetFileNames', 'GetLocalRoot', 'GetIssueDescription', 'Load',
+ 'GetFileNames', 'GetIssueProperties', 'GetLocalRoot',
+ 'GetIssueDescription', 'Load',
'MissingTests', 'NeedsUpload', 'PrimeLint', 'RpcServer', 'Save',
'SendToRietveld',
'SEPARATOR',
@@ -595,7 +597,7 @@ class CMDCommitUnittest(GclTestsBase):
self.assertTrue(change_info._closed)
self.assertEqual(
change_info._comments_added,
- ["Committed manually as r12345 (presubmit successful)."])
+ ["Committed patch #1 manually as r12345 (presubmit successful)."])
if __name__ == '__main__':
« git_cl.py ('K') | « git_cl.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698