Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1227583002: Revert of Remove chromeos==0 blacklist for test_isolation_mode. (Closed)

Created:
5 years, 5 months ago by tapted
Modified:
5 years, 5 months ago
Reviewers:
smut, M-A Ruel, smut
CC:
chromium-reviews, Reilly Grant (use Gerrit)
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove chromeos==0 blacklist for test_isolation_mode. (patchset #2 id:20001 of https://codereview.chromium.org/1214903013/) Reason for revert: fails 'compile on ChromiumOS x86-generic Compile, Link: https://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20x86-generic%20Compile/builds/1797 Error like [6346/6381] RULE interactive_ui_tests_run: isolate_66259a49d84685497c67f134062c657d interactive_ui_tests.isolate /* snip */ FAILED: cd ../../chrome; python ../tools/isolate_driver.py check --isolated "../out_x86-generic/Release/interactive_ui_tests.isolated" --isolate "interactive_ui_tests.isolate" /* snip */ Failed to find an input file: Input file /b/build/slave/ChromiumOS_x86-generic_Compile/build/src/out_x86-generic/Release/nacl_irt_x86_64.nexe doesn't exist Original issue's description: > Remove chromeos==0 blacklist for test_isolation_mode. > > All of plain linux, chromeos work just fine and have been for a long time. > > iOS and Android are also using .isolate files but in a different enough way that > it's not using test_isolation_mode==check, at least not yet. > > TBR=smut@chromium.org > BUG=98637 > > Committed: https://crrev.com/cf15207e009794f74915d9b10d2e838b0d0c86f2 > Cr-Commit-Position: refs/heads/master@{#337503} TBR=smut@chromium.org,smut@google.com,maruel@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=98637 Committed: https://crrev.com/f7c5ec7bcc7fd73d7927fad9bca9bd82c6f6e793 Cr-Commit-Position: refs/heads/master@{#337533}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tapted
Created Revert of Remove chromeos==0 blacklist for test_isolation_mode.
5 years, 5 months ago (2015-07-07 00:30:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227583002/1
5 years, 5 months ago (2015-07-07 00:31:06 UTC) #2
smut
lgtm
5 years, 5 months ago (2015-07-07 00:35:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-07 00:35:57 UTC) #4
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 00:37:09 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f7c5ec7bcc7fd73d7927fad9bca9bd82c6f6e793
Cr-Commit-Position: refs/heads/master@{#337533}

Powered by Google App Engine
This is Rietveld 408576698