Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Issue 1227523004: Add nanobench-style JSON output to llvm_coverage_run (Closed)

Created:
5 years, 5 months ago by borenet
Modified:
5 years, 5 months ago
Reviewers:
jcgregorio, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add nanobench-style JSON output to llvm_coverage_run Runs the build and run scripts for coverage, then dumps the results into a file in nanobench-compatible format. BUG=skia:2430 Committed: https://skia.googlesource.com/skia/+/334e588d9ed5390efb82beb37329b56a380f1d0e

Patch Set 1 #

Patch Set 2 : Fix potential issue in _nanobench_json #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -4 lines) Patch
M tools/llvm_coverage_run.py View 1 2 chunks +72 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
borenet
5 years, 5 months ago (2015-07-06 17:48:04 UTC) #2
jcgregorio
lgtm
5 years, 5 months ago (2015-07-06 18:02:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227523004/20001
5 years, 5 months ago (2015-07-06 18:11:29 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 18:18:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/334e588d9ed5390efb82beb37329b56a380f1d0e

Powered by Google App Engine
This is Rietveld 408576698