src/v8natives.js - Issue 1227523003: [es6] Bound function name - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(400)

My Issues | Starred Open | Closed | All

Unified Diff: src/v8natives.js

Issue 1227523003: [es6] Bound function name (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: git rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | test/mjsunit/function-bind-name.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/v8natives.js

diff --git a/src/v8natives.js b/src/v8natives.js

index 72cb8caa29c076e01856e9d76c9dc7c516226415..92769e25d2f0d96eda708111ee71533e66995d40 100644

--- a/src/v8natives.js

+++ b/src/v8natives.js

@@ -21,7 +21,6 @@ var GlobalFunction = global.Function;

var GlobalNumber = global.Number;

var GlobalObject = global.Object;

var InternalArray = utils.InternalArray;

-var SetFunctionName = utils.SetFunctionName;

var MathAbs;

var ProxyDelegateCallAndConstruct;

@@ -1705,7 +1704,8 @@ function FunctionBind(this_arg) { // Length is 1.

var name = this.name;

var bound_name = IS_STRING(name) ? name : "";

- SetFunctionName(result, bound_name, "bound");

+ %DefineDataPropertyUnchecked(result, "name", "bound " + bound_name,

+ DONT_ENUM | READ_ONLY);

// We already have caller and arguments properties on functions,

// which are non-configurable. It therefore makes no sence to

« no previous file with comments | « no previous file | test/mjsunit/function-bind-name.js » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698