Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 1227523003: [es6] Bound function name (Closed)

Created:
5 years, 5 months ago by arv (Not doing code reviews)
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Bound function name Instead of updating the SharedFuntionInfo set the name property on the function directly. BUG=v8:4278 LOG=N R=verwaest@chromium.org, littledan@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Committed: https://crrev.com/6d32be24fc19507107f55bd8ee0ca000b5919cb8 Cr-Commit-Position: refs/heads/master@{#29558}

Patch Set 1 #

Patch Set 2 : git rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M src/v8natives.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/function-bind-name.js View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
arv (Not doing code reviews)
PTAL I'll have to disable the stupid Blink tests again :'( https://codereview.chromium.org/1214113005/diff/1/LayoutTests/inspector/sources/debugger/properties-special-expected.txt?context=100&column_width=80&tab_spaces=8
5 years, 5 months ago (2015-07-06 16:55:52 UTC) #1
Toon Verwaest
lgtm
5 years, 5 months ago (2015-07-06 22:28:17 UTC) #2
Dan Ehrenberg
lgtm lgtm
5 years, 5 months ago (2015-07-08 23:20:48 UTC) #3
arv (Not doing code reviews)
git rebase
5 years, 5 months ago (2015-07-09 15:57:30 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227523003/20001
5 years, 5 months ago (2015-07-09 15:58:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227523003/20001
5 years, 5 months ago (2015-07-09 16:04:09 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/70456)
5 years, 5 months ago (2015-07-09 17:54:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227523003/20001
5 years, 5 months ago (2015-07-09 19:33:27 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-09 20:36:08 UTC) #15
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 20:36:32 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6d32be24fc19507107f55bd8ee0ca000b5919cb8
Cr-Commit-Position: refs/heads/master@{#29558}

Powered by Google App Engine
This is Rietveld 408576698