MIME type predicates and case-insensitive matching.

MIME type predicates and case-insensitive matching.

The registered type portion of a MIME type must be compared
case-insensitively for equality. Make all Blink-side predicates (e.g.,
is*MIMEType()) do such equality testing.

If the equality testing delegates to external platform predicates,
then ensure that the MIME type is first translated to lower case.
(This is due to the net/base/ MIME type predicates assuming
lower-cased input.)

The downstream benefit of this is that we can let go of various
explicit lower case conversions before invoking these predicates.

R=jochen
BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164453

[sof, 2014-01-02 08:26:17]

At your leisure (or when returning from such :) ), please take a look.

Just tidying up slightly; the MIME type predicates should perform
case-insensitive matching to avoid relying on the caller (to remember) to
normalize the type string first.

[jochen (gone - plz use gerrit), 2014-01-03 11:31:09]

https://codereview.chromium.org/122743002/diff/40001/Source/core/dom/DOMImple...
File Source/core/dom/DOMImplementation.cpp (right):

https://codereview.chromium.org/122743002/diff/40001/Source/core/dom/DOMImple...
Source/core/dom/DOMImplementation.cpp:238: return static_cast<UChar>(asciiUpper)
== (u & static_cast<UChar>(~0x20));
nit. use toASCIIUpper()

https://codereview.chromium.org/122743002/diff/40001/Source/core/dom/DOMImple...
Source/core/dom/DOMImplementation.cpp:258: ||
!equalToUpperCaseASCIIIgnoringCase('X', mimeType[length - 3])
why not !mimeType.endsWith("+xml", true)

[sof, 2014-01-03 13:51:02]

https://codereview.chromium.org/122743002/diff/40001/Source/core/dom/DOMImple...
File Source/core/dom/DOMImplementation.cpp (right):

https://codereview.chromium.org/122743002/diff/40001/Source/core/dom/DOMImple...
Source/core/dom/DOMImplementation.cpp:258: ||
!equalToUpperCaseASCIIIgnoringCase('X', mimeType[length - 3])
On 2014/01/03 11:31:09, jochen wrote:
> why not !mimeType.endsWith("+xml", true)

Nice; switched to this simpler form instead (removing the added helper in the
process.)

[jochen (gone - plz use gerrit), 2014-01-03 14:02:01]

lgtm

[commit-bot: I haz the power, 2014-01-03 15:53:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sigbjornf@opera.com/122743002/160001

[commit-bot: I haz the power, 2014-01-03 18:07:02]

Change committed as 164453