Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1227413002: Fix SkImage::asLegacyBitmap() rowBytes assert (Closed)

Created:
5 years, 5 months ago by f(malita)
Modified:
5 years, 5 months ago
Reviewers:
reed2, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix SkImage::asLegacyBitmap() rowBytes assert When reusing the pixel ref, we need to observe its rowBytes. R=reed@google.com Committed: https://skia.googlesource.com/skia/+/ea561bf055bb803f4c10ca323ea60a9d94da7956

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -17 lines) Patch
M src/image/SkImage_Raster.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SurfaceTest.cpp View 2 chunks +31 lines, -16 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227413002/1
5 years, 5 months ago (2015-07-09 21:13:11 UTC) #3
f(malita)
Found while playing with the new API in Blink: https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/70471/layout-test-results/fast/canvas/canvas-createImageBitmap-drawImage-stderr.txt
5 years, 5 months ago (2015-07-09 21:14:55 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-09 21:31:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227413002/1
5 years, 5 months ago (2015-07-09 21:32:34 UTC) #8
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 5 months ago (2015-07-09 21:32:36 UTC) #9
reed2
lgtm
5 years, 5 months ago (2015-07-10 00:08:27 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 00:10:35 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ea561bf055bb803f4c10ca323ea60a9d94da7956

Powered by Google App Engine
This is Rietveld 408576698