Add data files for base and net. Move GN Python proto outputs.

Add data files for base and net. Move GN Python proto outputs.

The "data" for net_unittests and base_unittests should match the isolates.

To make this work, the python outputs for protoc is updated to match GYP (all Python outputs go into a "pyproto" directory).

Targets were added for Pytho-only dependencies listing the data files. This way one only needs to depend on the target and implicitly get the associated data files.

The location of the google protobuf helpers is moved to match GYP.

R=dpranke

Committed: https://crrev.com/43ae0e159f885f53cb9ceb36ca606b37b399679c
Cr-Commit-Position: refs/heads/master@{#338741}

[brettw, 2015-07-09 19:59:35]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2015-07-09 19:59:41]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-07-09 20:00:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1227393002/20001

[commit-bot: I haz the power, 2015-07-09 20:10:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-09 20:10:10]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[brettw, 2015-07-09 20:28:36]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-07-09 20:29:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1227393002/40001

[commit-bot: I haz the power, 2015-07-09 21:55:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-09 21:55:47]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-07-09 22:16:48]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-07-09 22:18:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1227393002/40001

[commit-bot: I haz the power, 2015-07-09 23:50:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-09 23:50:20]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-07-10 19:18:10]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-07-10 19:19:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1227393002/40001

[commit-bot: I haz the power, 2015-07-10 20:25:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-10 20:25:45]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-07-10 23:31:09]

.

[brettw, 2015-07-10 23:32:23]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-07-10 23:35:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1227393002/60001

[commit-bot: I haz the power, 2015-07-11 00:43:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-11 00:43:59]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dirk Pranke, 2015-07-14 00:45:22]

https://codereview.chromium.org/1227393002/diff/60001/base/BUILD.gn
File base/BUILD.gn (right):

https://codereview.chromium.org/1227393002/diff/60001/base/BUILD.gn#newcode1424
base/BUILD.gn:1424: data += [ "//testing/test_env.py" ]
isn't this more a dependency of //base/test:test_support ? 

You're adding this here not because base_unittests needs this to run, but
because the isolate does, right? Currently MB adds this automatically
(mb.py:469), but it would be better (IMO) if this got declared via GN, as long
as there was a comment indicating *why* it's declared.

Also, maybe we should add xvfb.py inside an is_x11 block, for the same reason?

https://codereview.chromium.org/1227393002/diff/60001/base/BUILD.gn#newcode1439
base/BUILD.gn:1439: # isolate files.
We should probably discuss this at some point; it looks like there are android
rules to generate wrapper scripts to run the templates based on this (somehow)
that we might want to understand and genericize.

https://codereview.chromium.org/1227393002/diff/60001/net/BUILD.gn
File net/BUILD.gn (right):

https://codereview.chromium.org/1227393002/diff/60001/net/BUILD.gn#newcode1351
net/BUILD.gn:1351: "//testing/test_env.py",
same comment re: test_env.py .

[brettw, 2015-07-14 17:35:30]

PTAL, I added targets for different groups of data files. This seems like an
improvement over listing random dirs in third_party as data.

[brettw, 2015-07-14 17:35:35]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-14 17:36:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1227393002/100001

[commit-bot: I haz the power, 2015-07-14 18:05:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-14 18:05:59]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2015-07-14 20:36:22]

lgtm w/ comments addressed below.

https://codereview.chromium.org/1227393002/diff/100001/base/test/BUILD.gn
File base/test/BUILD.gn (right):

https://codereview.chromium.org/1227393002/diff/100001/base/test/BUILD.gn#new...
base/test/BUILD.gn:133: ]
Can you add a comment about *why* this is a dependency (the isolate needs this,
even if test_support doesn't actually use this).

And, also, we should figure out if there's a similar place we should add in a
dependency for xvfb.py. Currently mb adds it for everything on configs that use
x11, but perhaps that should be a dependency of something in //ui or something.

[brettw, 2015-07-14 20:57:30]

Added a comment. When I get to xvfb I'll probably just add some target in
//testing to do this since that's where the script is. //ui/gfx/x is the
X11-specific directory but it doesn't quite look appropriate for this.

[brettw, 2015-07-14 20:58:25]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-07-14 20:58:25]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1227393002/#ps120001
(title: " ")

[commit-bot: I haz the power, 2015-07-14 20:58:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1227393002/120001

[commit-bot: I haz the power, 2015-07-14 22:12:48]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-07-14 22:14:41]

Patchset 7 (id:??) landed as
https://crrev.com/43ae0e159f885f53cb9ceb36ca606b37b399679c
Cr-Commit-Position: refs/heads/master@{#338741}