Remove memset from VideoFrame and mark buffer as unpoisoned

media/base/video_frame_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/video_frame.h"
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
 #include "base/format_macros.h"
 #include "base/memory/aligned_memory.h"
@@ skipping 313 matching lines @@
     }
 
     SyncPointClientImpl client(release_sync_point);
     frame->UpdateReleaseSyncPoint(&client);
     EXPECT_EQ(sync_point,
               frame->mailbox_holder(VideoFrame::kYPlane).sync_point);
   }
   EXPECT_EQ(release_sync_point, called_sync_point);
 }
 
-TEST(VideoFrame, ZeroInitialized) {
+TEST(VideoFrame, InitializedAndZeroed) {

[DaleCurtis, 2015/07/09 23:29:44]

Just move to the frame pool unittests?

[emircan, 2015/07/10 00:22:53]

Done.

   const int kWidth = 64;
   const int kHeight = 48;
   const base::TimeDelta kTimestamp = base::TimeDelta::FromMicroseconds(1337);
 
   gfx::Size size(kWidth, kHeight);
   scoped_refptr<media::VideoFrame> frame = VideoFrame::CreateFrame(
       media::VideoFrame::YV12, size, gfx::Rect(size), size, kTimestamp);
+  memset(frame->data(0), 0, VideoFrame::AlignedAllocationSize(frame));
 
   for (size_t i = 0; i < VideoFrame::NumPlanes(frame->format()); ++i)
     EXPECT_EQ(0, frame->data(i)[0]);
 }
 
 TEST(VideoFrameMetadata, SetAndThenGetAllKeysForAllTypes) {
   VideoFrameMetadata metadata;
 
   for (int i = 0; i < VideoFrameMetadata::NUM_KEYS; ++i) {
     const VideoFrameMetadata::Key key = static_cast<VideoFrameMetadata::Key>(i);
@@ skipping 72 matching lines @@
 
   for (int i = 0; i < VideoFrameMetadata::NUM_KEYS; ++i) {
     const VideoFrameMetadata::Key key = static_cast<VideoFrameMetadata::Key>(i);
     int value = -1;
     EXPECT_TRUE(result.GetInteger(key, &value));
     EXPECT_EQ(i, value);
   }
 }
 
 }  // namespace media